jdk-jdk (original) (raw)

Code Review for jdk-jdk

Prepared by: shade on Thu Apr 26 17:38:50 CEST 2018
Workspace: /home/shade/trunks/jdk-jdk
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version: 49886
Summary of changes: 971 lines changed: 496 ins; 387 del; 88 mod; 18411 unchg
Changeset: <jdk-jdk.changeset>
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.cpp) src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

234 lines changed: 234 ins; 0 del; 0 mod; 122 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler%5Farm.hpp) src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

21 lines changed: 21 ins; 0 del; 0 mod; 39 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.hpp) src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

5 lines changed: 5 ins; 0 del; 0 mod; 42 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.cpp) src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

104 lines changed: 104 ins; 0 del; 0 mod; 74 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler%5Farm.hpp) src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

9 lines changed: 9 ins; 0 del; 0 mod; 37 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.cpp) src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

9 lines changed: 9 ins; 0 del; 0 mod; 44 unchg

[Cdiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler%5Farm.hpp) src/hotspot/cpu/arm/gc/shared/modRefBarrierSetAssembler_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

9 lines changed: 9 ins; 0 del; 0 mod; 45 unchg

[Cdiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/interp%5Fmasm%5Farm.cpp) src/hotspot/cpu/arm/interp_masm_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

85 lines changed: 0 ins; 85 del; 0 mod; 1991 unchg

[Cdiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/interp%5Fmasm%5Farm.hpp) src/hotspot/cpu/arm/interp_masm_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

5 lines changed: 0 ins; 5 del; 0 mod; 338 unchg

[Cdiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/macroAssembler%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/macroAssembler%5Farm.cpp) src/hotspot/cpu/arm/macroAssembler_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

231 lines changed: 17 ins; 197 del; 17 mod; 3047 unchg

[Cdiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp.sdiff.html) [Frames](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp.frames.html) [Old](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp-.html) [New](src/hotspot/cpu/arm/macroAssembler%5Farm.hpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/macroAssembler%5Farm.hpp) src/hotspot/cpu/arm/macroAssembler_arm.hpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

27 lines changed: 0 ins; 21 del; 6 mod; 1384 unchg

[Cdiffs](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/stubGenerator%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/stubGenerator%5Farm.cpp) src/hotspot/cpu/arm/stubGenerator_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

1 line changed: 0 ins; 0 del; 1 mod; 4384 unchg

[Cdiffs](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/templateInterpreterGenerator%5Farm.cpp) src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

74 lines changed: 0 ins; 27 del; 47 mod; 1907 unchg

[Cdiffs](src/hotspot/cpu/arm/templateTable%5Farm.cpp.cdiff.html) [Udiffs](src/hotspot/cpu/arm/templateTable%5Farm.cpp.udiff.html) [Sdiffs](src/hotspot/cpu/arm/templateTable%5Farm.cpp.sdiff.html) [Frames](src/hotspot/cpu/arm/templateTable%5Farm.cpp.frames.html) [Old](src/hotspot/cpu/arm/templateTable%5Farm.cpp-.html) [New](src/hotspot/cpu/arm/templateTable%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/templateTable%5Farm.cpp) src/hotspot/cpu/arm/templateTable_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

70 lines changed: 1 ins; 52 del; 17 mod; 4957 unchg

------ ------ ------ ------ ---[New](src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.cpp.html) -----[Raw](raw%5Ffiles/new/src/hotspot/cpu/arm/gc/shared/barrierSetAssembler%5Farm.cpp) src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp

rev 49887 : 8201786: Modularize interpreter GC barriers: leftovers for ARM32 Reviewed-by: XXX

87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/shade/trunks/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).