submit-hs (original) (raw)
Code Review for submit-hs
| Prepared by: | simonis on Tue Mar 13 18:04:50 CET 2018 |
|---|---|
| Workspace: | /priv/d046063/OpenJDK/submit-hs |
| Compare against version: | 49224 |
| Branch: | JDK-8199472 |
| Summary of changes: | 40 lines changed: 29 ins; 2 del; 9 mod; 13394 unchg |
| Patch of changes: | <submit-hs.patch> |
| Bug id: | JDK-8199472 : Fix non-PCH build after JDK-8199319 |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/hotspot/share/classfile/classListParser.cpp.cdiff.html) [Udiffs](src/hotspot/share/classfile/classListParser.cpp.udiff.html) [Sdiffs](src/hotspot/share/classfile/classListParser.cpp.sdiff.html) [Frames](src/hotspot/share/classfile/classListParser.cpp.frames.html) [Old](src/hotspot/share/classfile/classListParser.cpp-.html) [New](src/hotspot/share/classfile/classListParser.cpp.html) [Patch](src/hotspot/share/classfile/classListParser.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/classfile/classListParser.cpp) src/hotspot/share/classfile/classListParser.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 456 unchg
[Cdiffs](src/hotspot/share/classfile/classLoaderData.cpp.cdiff.html) [Udiffs](src/hotspot/share/classfile/classLoaderData.cpp.udiff.html) [Sdiffs](src/hotspot/share/classfile/classLoaderData.cpp.sdiff.html) [Frames](src/hotspot/share/classfile/classLoaderData.cpp.frames.html) [Old](src/hotspot/share/classfile/classLoaderData.cpp-.html) [New](src/hotspot/share/classfile/classLoaderData.cpp.html) [Patch](src/hotspot/share/classfile/classLoaderData.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/classfile/classLoaderData.cpp) src/hotspot/share/classfile/classLoaderData.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 1426 unchg
[Cdiffs](src/hotspot/share/classfile/stringTable.cpp.cdiff.html) [Udiffs](src/hotspot/share/classfile/stringTable.cpp.udiff.html) [Sdiffs](src/hotspot/share/classfile/stringTable.cpp.sdiff.html) [Frames](src/hotspot/share/classfile/stringTable.cpp.frames.html) [Old](src/hotspot/share/classfile/stringTable.cpp-.html) [New](src/hotspot/share/classfile/stringTable.cpp.html) [Patch](src/hotspot/share/classfile/stringTable.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/classfile/stringTable.cpp) src/hotspot/share/classfile/stringTable.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 762 unchg
[Cdiffs](src/hotspot/share/classfile/systemDictionaryShared.cpp.cdiff.html) [Udiffs](src/hotspot/share/classfile/systemDictionaryShared.cpp.udiff.html) [Sdiffs](src/hotspot/share/classfile/systemDictionaryShared.cpp.sdiff.html) [Frames](src/hotspot/share/classfile/systemDictionaryShared.cpp.frames.html) [Old](src/hotspot/share/classfile/systemDictionaryShared.cpp-.html) [New](src/hotspot/share/classfile/systemDictionaryShared.cpp.html) [Patch](src/hotspot/share/classfile/systemDictionaryShared.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/classfile/systemDictionaryShared.cpp) src/hotspot/share/classfile/systemDictionaryShared.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 1087 unchg
[Cdiffs](src/hotspot/share/classfile/verificationType.cpp.cdiff.html) [Udiffs](src/hotspot/share/classfile/verificationType.cpp.udiff.html) [Sdiffs](src/hotspot/share/classfile/verificationType.cpp.sdiff.html) [Frames](src/hotspot/share/classfile/verificationType.cpp.frames.html) [Old](src/hotspot/share/classfile/verificationType.cpp-.html) [New](src/hotspot/share/classfile/verificationType.cpp.html) [Patch](src/hotspot/share/classfile/verificationType.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/classfile/verificationType.cpp) src/hotspot/share/classfile/verificationType.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
2 lines changed: 1 ins; 0 del; 1 mod; 173 unchg
[Cdiffs](src/hotspot/share/code/icBuffer.cpp.cdiff.html) [Udiffs](src/hotspot/share/code/icBuffer.cpp.udiff.html) [Sdiffs](src/hotspot/share/code/icBuffer.cpp.sdiff.html) [Frames](src/hotspot/share/code/icBuffer.cpp.frames.html) [Old](src/hotspot/share/code/icBuffer.cpp-.html) [New](src/hotspot/share/code/icBuffer.cpp.html) [Patch](src/hotspot/share/code/icBuffer.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/code/icBuffer.cpp) src/hotspot/share/code/icBuffer.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 233 unchg
[Cdiffs](src/hotspot/share/code/location.cpp.cdiff.html) [Udiffs](src/hotspot/share/code/location.cpp.udiff.html) [Sdiffs](src/hotspot/share/code/location.cpp.sdiff.html) [Frames](src/hotspot/share/code/location.cpp.frames.html) [Old](src/hotspot/share/code/location.cpp-.html) [New](src/hotspot/share/code/location.cpp.html) [Patch](src/hotspot/share/code/location.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/code/location.cpp) src/hotspot/share/code/location.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
2 lines changed: 1 ins; 0 del; 1 mod; 70 unchg
[Cdiffs](src/hotspot/share/compiler/oopMap.cpp.cdiff.html) [Udiffs](src/hotspot/share/compiler/oopMap.cpp.udiff.html) [Sdiffs](src/hotspot/share/compiler/oopMap.cpp.sdiff.html) [Frames](src/hotspot/share/compiler/oopMap.cpp.frames.html) [Old](src/hotspot/share/compiler/oopMap.cpp-.html) [New](src/hotspot/share/compiler/oopMap.cpp.html) [Patch](src/hotspot/share/compiler/oopMap.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/compiler/oopMap.cpp) src/hotspot/share/compiler/oopMap.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
2 lines changed: 1 ins; 0 del; 1 mod; 821 unchg
[Cdiffs](src/hotspot/share/memory/oopFactory.cpp.cdiff.html) [Udiffs](src/hotspot/share/memory/oopFactory.cpp.udiff.html) [Sdiffs](src/hotspot/share/memory/oopFactory.cpp.sdiff.html) [Frames](src/hotspot/share/memory/oopFactory.cpp.frames.html) [Old](src/hotspot/share/memory/oopFactory.cpp-.html) [New](src/hotspot/share/memory/oopFactory.cpp.html) [Patch](src/hotspot/share/memory/oopFactory.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/memory/oopFactory.cpp) src/hotspot/share/memory/oopFactory.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 98 unchg
[Cdiffs](src/hotspot/share/oops/arrayKlass.cpp.cdiff.html) [Udiffs](src/hotspot/share/oops/arrayKlass.cpp.udiff.html) [Sdiffs](src/hotspot/share/oops/arrayKlass.cpp.sdiff.html) [Frames](src/hotspot/share/oops/arrayKlass.cpp.frames.html) [Old](src/hotspot/share/oops/arrayKlass.cpp-.html) [New](src/hotspot/share/oops/arrayKlass.cpp.html) [Patch](src/hotspot/share/oops/arrayKlass.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/oops/arrayKlass.cpp) src/hotspot/share/oops/arrayKlass.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 246 unchg
[Cdiffs](src/hotspot/share/oops/instanceKlass.cpp.cdiff.html) [Udiffs](src/hotspot/share/oops/instanceKlass.cpp.udiff.html) [Sdiffs](src/hotspot/share/oops/instanceKlass.cpp.sdiff.html) [Frames](src/hotspot/share/oops/instanceKlass.cpp.frames.html) [Old](src/hotspot/share/oops/instanceKlass.cpp-.html) [New](src/hotspot/share/oops/instanceKlass.cpp.html) [Patch](src/hotspot/share/oops/instanceKlass.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/oops/instanceKlass.cpp) src/hotspot/share/oops/instanceKlass.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
4 lines changed: 4 ins; 0 del; 0 mod; 3752 unchg
[Cdiffs](src/hotspot/share/oops/instanceKlass.hpp.cdiff.html) [Udiffs](src/hotspot/share/oops/instanceKlass.hpp.udiff.html) [Sdiffs](src/hotspot/share/oops/instanceKlass.hpp.sdiff.html) [Frames](src/hotspot/share/oops/instanceKlass.hpp.frames.html) [Old](src/hotspot/share/oops/instanceKlass.hpp-.html) [New](src/hotspot/share/oops/instanceKlass.hpp.html) [Patch](src/hotspot/share/oops/instanceKlass.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/oops/instanceKlass.hpp) src/hotspot/share/oops/instanceKlass.hpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 0 ins; 0 del; 1 mod; 1507 unchg
[Cdiffs](src/hotspot/share/oops/klass.cpp.cdiff.html) [Udiffs](src/hotspot/share/oops/klass.cpp.udiff.html) [Sdiffs](src/hotspot/share/oops/klass.cpp.sdiff.html) [Frames](src/hotspot/share/oops/klass.cpp.frames.html) [Old](src/hotspot/share/oops/klass.cpp-.html) [New](src/hotspot/share/oops/klass.cpp.html) [Patch](src/hotspot/share/oops/klass.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/oops/klass.cpp) src/hotspot/share/oops/klass.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 860 unchg
[Cdiffs](src/hotspot/share/runtime/handles.hpp.cdiff.html) [Udiffs](src/hotspot/share/runtime/handles.hpp.udiff.html) [Sdiffs](src/hotspot/share/runtime/handles.hpp.sdiff.html) [Frames](src/hotspot/share/runtime/handles.hpp.frames.html) [Old](src/hotspot/share/runtime/handles.hpp-.html) [New](src/hotspot/share/runtime/handles.hpp.html) [Patch](src/hotspot/share/runtime/handles.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/runtime/handles.hpp) src/hotspot/share/runtime/handles.hpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
4 lines changed: 0 ins; 2 del; 2 mod; 297 unchg
[Cdiffs](src/hotspot/share/runtime/handles.inline.hpp.cdiff.html) [Udiffs](src/hotspot/share/runtime/handles.inline.hpp.udiff.html) [Sdiffs](src/hotspot/share/runtime/handles.inline.hpp.sdiff.html) [Frames](src/hotspot/share/runtime/handles.inline.hpp.frames.html) [Old](src/hotspot/share/runtime/handles.inline.hpp-.html) [New](src/hotspot/share/runtime/handles.inline.hpp.html) [Patch](src/hotspot/share/runtime/handles.inline.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/runtime/handles.inline.hpp) src/hotspot/share/runtime/handles.inline.hpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
12 lines changed: 11 ins; 0 del; 1 mod; 95 unchg
[Cdiffs](src/hotspot/share/runtime/jniHandles.cpp.cdiff.html) [Udiffs](src/hotspot/share/runtime/jniHandles.cpp.udiff.html) [Sdiffs](src/hotspot/share/runtime/jniHandles.cpp.sdiff.html) [Frames](src/hotspot/share/runtime/jniHandles.cpp.frames.html) [Old](src/hotspot/share/runtime/jniHandles.cpp-.html) [New](src/hotspot/share/runtime/jniHandles.cpp.html) [Patch](src/hotspot/share/runtime/jniHandles.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/runtime/jniHandles.cpp) src/hotspot/share/runtime/jniHandles.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
1 line changed: 1 ins; 0 del; 0 mod; 658 unchg
[Cdiffs](src/hotspot/share/services/diagnosticFramework.cpp.cdiff.html) [Udiffs](src/hotspot/share/services/diagnosticFramework.cpp.udiff.html) [Sdiffs](src/hotspot/share/services/diagnosticFramework.cpp.sdiff.html) [Frames](src/hotspot/share/services/diagnosticFramework.cpp.frames.html) [Old](src/hotspot/share/services/diagnosticFramework.cpp-.html) [New](src/hotspot/share/services/diagnosticFramework.cpp.html) [Patch](src/hotspot/share/services/diagnosticFramework.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/services/diagnosticFramework.cpp) src/hotspot/share/services/diagnosticFramework.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
2 lines changed: 1 ins; 0 del; 1 mod; 575 unchg
[Cdiffs](src/hotspot/share/services/memoryService.cpp.cdiff.html) [Udiffs](src/hotspot/share/services/memoryService.cpp.udiff.html) [Sdiffs](src/hotspot/share/services/memoryService.cpp.sdiff.html) [Frames](src/hotspot/share/services/memoryService.cpp.frames.html) [Old](src/hotspot/share/services/memoryService.cpp-.html) [New](src/hotspot/share/services/memoryService.cpp.html) [Patch](src/hotspot/share/services/memoryService.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/services/memoryService.cpp) src/hotspot/share/services/memoryService.cpp
rev 49225 : 8199472: Fix non-PCH build after JDK-8199319 Reviewed-by: coleenp, stefank
2 lines changed: 1 ins; 0 del; 1 mod; 278 unchg
This code review page was prepared using /usr/work/d046063/OpenJDK/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).