open (original) (raw)

Code Review for open

Prepared by: sjohanss on Tue Nov 27 18:26:21 CET 2018
Workspace: /home/sjohanss/repos/jdk/hs/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version: AMGC-tsch-rev2
Summary of changes: 73 lines changed: 58 ins; 8 del; 7 mod; 7829 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectedHeap.cpp-.html) [New](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectedHeap.cpp) src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52677 : imported patch AMGC-tsch-rev1 rev 52678 : imported patch AMGC-tsch-rev1-optcset rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

9 lines changed: 5 ins; 0 del; 4 mod; 4818 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1CollectionSet.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectionSet.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectionSet.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectionSet.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectionSet.cpp-.html) [New](src/hotspot/share/gc/g1/g1CollectionSet.cpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectionSet.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectionSet.cpp) src/hotspot/share/gc/g1/g1CollectionSet.cpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52677 : imported patch AMGC-tsch-rev1 rev 52678 : imported patch AMGC-tsch-rev1-optcset rev 52680 : imported patch AMGC-tsch-rev2 rev 52681 : [mq]: AMGC-kbar-rev1

5 lines changed: 5 ins; 0 del; 0 mod; 693 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1CollectionSet.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectionSet.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectionSet.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectionSet.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectionSet.hpp-.html) [New](src/hotspot/share/gc/g1/g1CollectionSet.hpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectionSet.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectionSet.hpp) src/hotspot/share/gc/g1/g1CollectionSet.hpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52677 : imported patch AMGC-tsch-rev1 rev 52678 : imported patch AMGC-tsch-rev1-optcset rev 52681 : [mq]: AMGC-kbar-rev1

4 lines changed: 3 ins; 0 del; 1 mod; 275 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp-.html) [New](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.html) [Patch](src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp) src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

4 lines changed: 4 ins; 0 del; 0 mod; 592 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp-.html) [New](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.html) [Patch](src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp) src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52679 : imported patch AMGC-tsch-rev1-log rev 52680 : imported patch AMGC-tsch-rev2 rev 52681 : [mq]: AMGC-kbar-rev1

2 lines changed: 2 ins; 0 del; 0 mod; 426 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp-.html) [New](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.html) [Patch](src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp) src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

11 lines changed: 11 ins; 0 del; 0 mod; 42 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp-.html) [New](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.html) [Patch](src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp) src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

1 line changed: 1 ins; 0 del; 0 mod; 61 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp-.html) [New](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.html) [Patch](src/hotspot/share/gc/g1/g1ParScanThreadState.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1ParScanThreadState.cpp) src/hotspot/share/gc/g1/g1ParScanThreadState.cpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

23 lines changed: 13 ins; 8 del; 2 mod; 411 unchg

[Cdiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp-.html) [New](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.html) [Patch](src/hotspot/share/gc/g1/g1ParScanThreadState.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1ParScanThreadState.hpp) src/hotspot/share/gc/g1/g1ParScanThreadState.hpp

rev 52675 : 8213890: Implementation of JEP 344: Abortable Mixed Collections for G1 Reviewed-by: Contributed-by: erik.helin@oracle.com, stefan.johansson@oracle.com rev 52676 : imported patch AMGC-impl rev 52681 : [mq]: AMGC-kbar-rev1

1 line changed: 1 ins; 0 del; 0 mod; 251 unchg

[Cdiffs](src/hotspot/share/gc/shared/workerDataArray.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/shared/workerDataArray.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/shared/workerDataArray.hpp.sdiff.html) [Frames](src/hotspot/share/gc/shared/workerDataArray.hpp.frames.html) [Old](src/hotspot/share/gc/shared/workerDataArray.hpp-.html) [New](src/hotspot/share/gc/shared/workerDataArray.hpp.html) [Patch](src/hotspot/share/gc/shared/workerDataArray.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/shared/workerDataArray.hpp) src/hotspot/share/gc/shared/workerDataArray.hpp

rev 52679 : imported patch AMGC-tsch-rev1-log rev 52681 : [mq]: AMGC-kbar-rev1

2 lines changed: 2 ins; 0 del; 0 mod; 91 unchg

[Cdiffs](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.sdiff.html) [Frames](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.frames.html) [Old](src/hotspot/share/gc/shared/workerDataArray.inline.hpp-.html) [New](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.html) [Patch](src/hotspot/share/gc/shared/workerDataArray.inline.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/shared/workerDataArray.inline.hpp) src/hotspot/share/gc/shared/workerDataArray.inline.hpp

rev 52681 : [mq]: AMGC-kbar-rev1

11 lines changed: 11 ins; 0 del; 0 mod; 169 unchg


This code review page was prepared using /home/sjohanss/repos/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).