hotspot (original) (raw)

Code Review for hotspot

Prepared by: sla on Thu Feb 21 15:43:41 CET 2013
Workspace: /Users/staffan/mercurial/hotspot-rt-jdk/hotspot
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-rt-gate/hotspot
Compare against version: 4174
Summary of changes: 5862 lines changed: 8 ins; 5765 del; 89 mod; 2817 unchg
Patch of changes: <hotspot.patch>
Bug id: 7165259 Remove BugSpot
Legend: Modified file Deleted file New file

[Cdiffs](agent/make/Makefile.cdiff.html) [Udiffs](agent/make/Makefile.udiff.html) [Sdiffs](agent/make/Makefile.sdiff.html) [Frames](agent/make/Makefile.frames.html) [Old](agent/make/Makefile-.html) [New](agent/make/Makefile.html) [Patch](agent/make/Makefile.patch) [Raw](raw%5Ffiles/new/agent/make/Makefile) agent/make/Makefile

rev 4175 : [mq]: remove-bugspot

10 lines changed: 0 ins; 6 del; 4 mod; 307 unchg

[Cdiffs](agent/make/marks%5Fnotes.html.cdiff.html) [Udiffs](agent/make/marks%5Fnotes.html.udiff.html) [Sdiffs](agent/make/marks%5Fnotes.html.sdiff.html) [Frames](agent/make/marks%5Fnotes.html.frames.html) [Old](agent/make/marks%5Fnotes.html-.html) [New](agent/make/marks%5Fnotes.html.html) [Patch](agent/make/marks%5Fnotes.html.patch) [Raw](raw%5Ffiles/new/agent/make/marks%5Fnotes.html) agent/make/marks_notes.html

rev 4175 : [mq]: remove-bugspot

9 lines changed: 0 ins; 6 del; 3 mod; 90 unchg

[Cdiffs](agent/src/os/win32/windbg/sawindbg.cpp.cdiff.html) [Udiffs](agent/src/os/win32/windbg/sawindbg.cpp.udiff.html) [Sdiffs](agent/src/os/win32/windbg/sawindbg.cpp.sdiff.html) [Frames](agent/src/os/win32/windbg/sawindbg.cpp.frames.html) [Old](agent/src/os/win32/windbg/sawindbg.cpp-.html) [New](agent/src/os/win32/windbg/sawindbg.cpp.html) [Patch](agent/src/os/win32/windbg/sawindbg.cpp.patch) [Raw](raw%5Ffiles/new/agent/src/os/win32/windbg/sawindbg.cpp) agent/src/os/win32/windbg/sawindbg.cpp

rev 4175 : [mq]: remove-bugspot

2 lines changed: 0 ins; 1 del; 1 mod; 877 unchg

[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java) agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java

rev 4175 : [mq]: remove-bugspot

4 lines changed: 0 ins; 4 del; 0 mod; 66 unchg

[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java) agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java

rev 4175 : [mq]: remove-bugspot

79 lines changed: 0 ins; 14 del; 65 mod; 193 unchg

[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java) agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java

rev 4175 : [mq]: remove-bugspot

45 lines changed: 8 ins; 23 del; 14 mod; 193 unchg

[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java) agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java

rev 4175 : [mq]: remove-bugspot

1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js-.html) [New](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js) agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js

rev 4175 : [mq]: remove-bugspot

2 lines changed: 0 ins; 2 del; 0 mod; 862 unchg

[Cdiffs](make/sa.files.cdiff.html) [Udiffs](make/sa.files.udiff.html) [Sdiffs](make/sa.files.sdiff.html) [Frames](make/sa.files.frames.html) [Old](make/sa.files-.html) [New](make/sa.files.html) [Patch](make/sa.files.patch) [Raw](raw%5Ffiles/new/make/sa.files) make/sa.files

rev 4175 : [mq]: remove-bugspot

7 lines changed: 0 ins; 6 del; 1 mod; 113 unchg

------ ------ ------ ------[Old](agent/make/bugspot.bat-.html) ---[Patch](agent/make/bugspot.bat.patch) --- agent/make/bugspot.bat

25 lines changed: 0 ins; 25 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java

1536 lines changed: 0 ins; 1536 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java

799 lines changed: 0 ins; 799 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java

55 lines changed: 0 ins; 55 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java

52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java

96 lines changed: 0 ins; 96 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java

89 lines changed: 0 ins; 89 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java

173 lines changed: 0 ins; 173 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java

87 lines changed: 0 ins; 87 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java

115 lines changed: 0 ins; 115 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java

237 lines changed: 0 ins; 237 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java

252 lines changed: 0 ins; 252 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java

73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java

216 lines changed: 0 ins; 216 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java

51 lines changed: 0 ins; 51 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java

41 lines changed: 0 ins; 41 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java

54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java-.html) ---[Patch](agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java.patch) --- agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java

415 lines changed: 0 ins; 415 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/native/jvmdi/sa.cpp-.html) ---[Patch](agent/src/share/native/jvmdi/sa.cpp.patch) --- agent/src/share/native/jvmdi/sa.cpp

601 lines changed: 0 ins; 601 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/native/jvmdi/sa.dsp-.html) ---[Patch](agent/src/share/native/jvmdi/sa.dsp.patch) --- agent/src/share/native/jvmdi/sa.dsp

105 lines changed: 0 ins; 105 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/native/jvmdi/sa.dsw-.html) ---[Patch](agent/src/share/native/jvmdi/sa.dsw.patch) --- agent/src/share/native/jvmdi/sa.dsw

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------[Old](agent/src/share/native/jvmdi/sa.hpp-.html) ---[Patch](agent/src/share/native/jvmdi/sa.hpp.patch) --- agent/src/share/native/jvmdi/sa.hpp

30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg


This code review page was prepared using /Users/staffan/bin/webrev(vers 23.18-hg).