hotspot (original) (raw)
Code Review for hotspot
| Prepared by: | sla on Thu Jan 17 20:39:41 CET 2013 |
|---|---|
| Workspace: | /Users/staffan/mercurial/hotspot-rt-jdk/hotspot |
| Compare against: | http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot |
| Compare against version: | 3966 |
| Summary of changes: | 168 lines changed: 121 ins; 1 del; 46 mod; 6146 unchg |
| Patch of changes: | <hotspot.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](agent/src/os/bsd/MacosxDebuggerLocal.m.cdiff.html) [Udiffs](agent/src/os/bsd/MacosxDebuggerLocal.m.udiff.html) [Sdiffs](agent/src/os/bsd/MacosxDebuggerLocal.m.sdiff.html) [Frames](agent/src/os/bsd/MacosxDebuggerLocal.m.frames.html) [Old](agent/src/os/bsd/MacosxDebuggerLocal.m-.html) [New](agent/src/os/bsd/MacosxDebuggerLocal.m.html) [Patch](agent/src/os/bsd/MacosxDebuggerLocal.m.patch) [Raw](raw%5Ffiles/new/agent/src/os/bsd/MacosxDebuggerLocal.m) agent/src/os/bsd/MacosxDebuggerLocal.m
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
109 lines changed: 86 ins; 0 del; 23 mod; 553 unchg
[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java) agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 82 unchg
[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java) agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
12 lines changed: 5 ins; 0 del; 7 mod; 596 unchg
[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java) agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
10 lines changed: 2 ins; 0 del; 8 mod; 73 unchg
[Cdiffs](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.cdiff.html) [Udiffs](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.udiff.html) [Sdiffs](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.sdiff.html) [Frames](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.frames.html) [Old](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java-.html) [New](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.html) [Patch](agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java.patch) [Raw](raw%5Ffiles/new/agent/src/share/classes/sun/jvm/hotspot/runtime/bsd%5Famd64/BsdAMD64JavaThreadPDAccess.java) agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
9 lines changed: 5 ins; 0 del; 4 mod; 128 unchg
[Cdiffs](src/os/bsd/vm/osThread%5Fbsd.hpp.cdiff.html) [Udiffs](src/os/bsd/vm/osThread%5Fbsd.hpp.udiff.html) [Sdiffs](src/os/bsd/vm/osThread%5Fbsd.hpp.sdiff.html) [Frames](src/os/bsd/vm/osThread%5Fbsd.hpp.frames.html) [Old](src/os/bsd/vm/osThread%5Fbsd.hpp-.html) [New](src/os/bsd/vm/osThread%5Fbsd.hpp.html) [Patch](src/os/bsd/vm/osThread%5Fbsd.hpp.patch) [Raw](raw%5Ffiles/new/src/os/bsd/vm/osThread%5Fbsd.hpp) src/os/bsd/vm/osThread_bsd.hpp
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
9 lines changed: 9 ins; 0 del; 0 mod; 143 unchg
[Cdiffs](src/os/bsd/vm/os%5Fbsd.cpp.cdiff.html) [Udiffs](src/os/bsd/vm/os%5Fbsd.cpp.udiff.html) [Sdiffs](src/os/bsd/vm/os%5Fbsd.cpp.sdiff.html) [Frames](src/os/bsd/vm/os%5Fbsd.cpp.frames.html) [Old](src/os/bsd/vm/os%5Fbsd.cpp-.html) [New](src/os/bsd/vm/os%5Fbsd.cpp.html) [Patch](src/os/bsd/vm/os%5Fbsd.cpp.patch) [Raw](raw%5Ffiles/new/src/os/bsd/vm/os%5Fbsd.cpp) src/os/bsd/vm/os_bsd.cpp
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
14 lines changed: 14 ins; 0 del; 0 mod; 4521 unchg
[Cdiffs](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.cdiff.html) [Udiffs](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.udiff.html) [Sdiffs](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.sdiff.html) [Frames](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.frames.html) [Old](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp-.html) [New](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.html) [Patch](src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp.patch) [Raw](raw%5Ffiles/new/src/os%5Fcpu/bsd%5Fx86/vm/vmStructs%5Fbsd%5Fx86.hpp) src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp
rev 3967 : 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Reviewed-by:
4 lines changed: 0 ins; 1 del; 3 mod; 50 unchg
This code review page was prepared using /Users/staffan/bin/webrev(vers 23.18-hg).