open (original) (raw)
Code Review for open
| Prepared by: | smarks on Thu Dec 7 15:57:45 PST 2017 |
|---|---|
| Workspace: | /Users/src/jdk-dev/jdk10-closed/open |
| Compare against version: | -2 |
| Summary of changes: | 119 lines changed: 99 ins; 16 del; 4 mod; 2317 unchg |
| Patch of changes: | <open.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/java.base/share/classes/java/util/Optional.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/Optional.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/Optional.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/Optional.java.frames.html) [Old](src/java.base/share/classes/java/util/Optional.java-.html) [New](src/java.base/share/classes/java/util/Optional.java.html) [Patch](src/java.base/share/classes/java/util/Optional.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/Optional.java) src/java.base/share/classes/java/util/Optional.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
20 lines changed: 15 ins; 4 del; 1 mod; 441 unchg
[Cdiffs](src/java.base/share/classes/java/util/OptionalDouble.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/OptionalDouble.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/OptionalDouble.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/OptionalDouble.java.frames.html) [Old](src/java.base/share/classes/java/util/OptionalDouble.java-.html) [New](src/java.base/share/classes/java/util/OptionalDouble.java.html) [Patch](src/java.base/share/classes/java/util/OptionalDouble.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/OptionalDouble.java) src/java.base/share/classes/java/util/OptionalDouble.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
20 lines changed: 15 ins; 4 del; 1 mod; 308 unchg
[Cdiffs](src/java.base/share/classes/java/util/OptionalInt.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/OptionalInt.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/OptionalInt.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/OptionalInt.java.frames.html) [Old](src/java.base/share/classes/java/util/OptionalInt.java-.html) [New](src/java.base/share/classes/java/util/OptionalInt.java.html) [Patch](src/java.base/share/classes/java/util/OptionalInt.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/OptionalInt.java) src/java.base/share/classes/java/util/OptionalInt.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
20 lines changed: 15 ins; 4 del; 1 mod; 306 unchg
[Cdiffs](src/java.base/share/classes/java/util/OptionalLong.java.cdiff.html) [Udiffs](src/java.base/share/classes/java/util/OptionalLong.java.udiff.html) [Sdiffs](src/java.base/share/classes/java/util/OptionalLong.java.sdiff.html) [Frames](src/java.base/share/classes/java/util/OptionalLong.java.frames.html) [Old](src/java.base/share/classes/java/util/OptionalLong.java-.html) [New](src/java.base/share/classes/java/util/OptionalLong.java.html) [Patch](src/java.base/share/classes/java/util/OptionalLong.java.patch) [Raw](raw%5Ffiles/new/src/java.base/share/classes/java/util/OptionalLong.java) src/java.base/share/classes/java/util/OptionalLong.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
20 lines changed: 15 ins; 4 del; 1 mod; 306 unchg
[Cdiffs](test/jdk/java/util/Optional/Basic.java.cdiff.html) [Udiffs](test/jdk/java/util/Optional/Basic.java.udiff.html) [Sdiffs](test/jdk/java/util/Optional/Basic.java.sdiff.html) [Frames](test/jdk/java/util/Optional/Basic.java.frames.html) [Old](test/jdk/java/util/Optional/Basic.java-.html) [New](test/jdk/java/util/Optional/Basic.java.html) [Patch](test/jdk/java/util/Optional/Basic.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Optional/Basic.java) test/jdk/java/util/Optional/Basic.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
12 lines changed: 12 ins; 0 del; 0 mod; 359 unchg
[Cdiffs](test/jdk/java/util/Optional/BasicDouble.java.cdiff.html) [Udiffs](test/jdk/java/util/Optional/BasicDouble.java.udiff.html) [Sdiffs](test/jdk/java/util/Optional/BasicDouble.java.sdiff.html) [Frames](test/jdk/java/util/Optional/BasicDouble.java.frames.html) [Old](test/jdk/java/util/Optional/BasicDouble.java-.html) [New](test/jdk/java/util/Optional/BasicDouble.java.html) [Patch](test/jdk/java/util/Optional/BasicDouble.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Optional/BasicDouble.java) test/jdk/java/util/Optional/BasicDouble.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
9 lines changed: 9 ins; 0 del; 0 mod; 199 unchg
[Cdiffs](test/jdk/java/util/Optional/BasicInt.java.cdiff.html) [Udiffs](test/jdk/java/util/Optional/BasicInt.java.udiff.html) [Sdiffs](test/jdk/java/util/Optional/BasicInt.java.sdiff.html) [Frames](test/jdk/java/util/Optional/BasicInt.java.frames.html) [Old](test/jdk/java/util/Optional/BasicInt.java-.html) [New](test/jdk/java/util/Optional/BasicInt.java.html) [Patch](test/jdk/java/util/Optional/BasicInt.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Optional/BasicInt.java) test/jdk/java/util/Optional/BasicInt.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
9 lines changed: 9 ins; 0 del; 0 mod; 199 unchg
[Cdiffs](test/jdk/java/util/Optional/BasicLong.java.cdiff.html) [Udiffs](test/jdk/java/util/Optional/BasicLong.java.udiff.html) [Sdiffs](test/jdk/java/util/Optional/BasicLong.java.sdiff.html) [Frames](test/jdk/java/util/Optional/BasicLong.java.frames.html) [Old](test/jdk/java/util/Optional/BasicLong.java-.html) [New](test/jdk/java/util/Optional/BasicLong.java.html) [Patch](test/jdk/java/util/Optional/BasicLong.java.patch) [Raw](raw%5Ffiles/new/test/jdk/java/util/Optional/BasicLong.java) test/jdk/java/util/Optional/BasicLong.java
rev 48216 : 8140281: add no-arg Optional.orElseThrow() as preferred alternative to get() Reviewed-by: XXX
9 lines changed: 9 ins; 0 del; 0 mod; 199 unchg
This code review page was prepared using /Users/smarks/bin/webrev(vers 25.16-hg+openjdk.java.net).