open (original) (raw)

Code Review for open

Prepared by: tschatzl on Mon Dec 11 11:49:52 CET 2017
Workspace: /home/tschatzl/Downloads/vmshare/jdk10/hs/open
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version: -2
Summary of changes: 9 lines changed: 4 ins; 2 del; 3 mod; 5384 unchg
Patch of changes: <open.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectedHeap.cpp-.html) [New](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectedHeap.cpp) src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 48252 : 8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME Summary: During a minor GC, if memory allocation fails, start a full GC within the same VM operation in the same safepoint. This avoids a race where the GC locker can prevent the full GC from occurring, and a premature OoME. Reviewed-by: Contributed-by: thomas.schatzl@oracle.com, axel.siebenborn@sap.com rev 48253 : [mq]: 8137099-phohensee-review

5 lines changed: 2 ins; 0 del; 3 mod; 5338 unchg

[Cdiffs](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.cdiff.html) [Udiffs](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.udiff.html) [Sdiffs](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.sdiff.html) [Frames](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.frames.html) [Old](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c-.html) [New](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.html) [Patch](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c) test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c

rev 48251 : imported patch 8137099-add-testcase rev 48253 : [mq]: 8137099-phohensee-review

4 lines changed: 2 ins; 2 del; 0 mod; 46 unchg


This code review page was prepared using ../../../tools/webrev.sh(vers 25.6-hg+openjdk.java.net).