open (original) (raw)
Code Review for open
Prepared by: | tschatzl on Mon Dec 11 11:46:15 CET 2017 |
---|---|
Workspace: | /home/tschatzl/Downloads/vmshare/jdk10/hs/open |
Compare against: | http://hg.openjdk.java.net/jdk/hs |
Compare against version: | -4 |
Summary of changes: | 492 lines changed: 287 ins; 141 del; 64 mod; 7631 unchg |
Patch of changes: | <open.patch> |
Legend: | Modified file Deleted file New file |
[Cdiffs](make/test/JtregNativeHotspot.gmk.cdiff.html) [Udiffs](make/test/JtregNativeHotspot.gmk.udiff.html) [Sdiffs](make/test/JtregNativeHotspot.gmk.sdiff.html) [Frames](make/test/JtregNativeHotspot.gmk.frames.html) [Old](make/test/JtregNativeHotspot.gmk-.html) [New](make/test/JtregNativeHotspot.gmk.html) [Patch](make/test/JtregNativeHotspot.gmk.patch) [Raw](raw%5Ffiles/new/make/test/JtregNativeHotspot.gmk)
make/test/JtregNativeHotspot.gmk
rev 48251 : imported patch 8137099-add-testcase
1 line changed: 1 ins; 0 del; 0 mod; 164 unchg
[Cdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectedHeap.cpp-.html) [New](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectedHeap.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectedHeap.cpp)
src/hotspot/share/gc/g1/g1CollectedHeap.cpp
160 lines changed: 23 ins; 89 del; 48 mod; 5272 unchg
[Cdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.frames.html) [Old](src/hotspot/share/gc/g1/g1CollectedHeap.hpp-.html) [New](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.html) [Patch](src/hotspot/share/gc/g1/g1CollectedHeap.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/g1CollectedHeap.hpp)
src/hotspot/share/gc/g1/g1CollectedHeap.hpp
rev 48252 : 8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME Summary: During a minor GC, if memory allocation fails, start a full GC within the same VM operation in the same safepoint. This avoids a race where the GC locker can prevent the full GC from occurring, and a premature OoME. Reviewed-by: Contributed-by: thomas.schatzl@oracle.com, axel.siebenborn@sap.com
18 lines changed: 0 ins; 15 del; 3 mod; 1539 unchg
[Cdiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.frames.html) [Old](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp-.html) [New](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.html) [Patch](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.cpp)
src/hotspot/share/gc/g1/vm_operations_g1.cpp
rev 48252 : 8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME Summary: During a minor GC, if memory allocation fails, start a full GC within the same VM operation in the same safepoint. This avoids a race where the GC locker can prevent the full GC from occurring, and a premature OoME. Reviewed-by: Contributed-by: thomas.schatzl@oracle.com, axel.siebenborn@sap.com
42 lines changed: 12 ins; 20 del; 10 mod; 196 unchg
[Cdiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.cdiff.html) [Udiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.udiff.html) [Sdiffs](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.sdiff.html) [Frames](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.frames.html) [Old](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp-.html) [New](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.html) [Patch](src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp.patch) [Raw](raw%5Ffiles/new/src/hotspot/share/gc/g1/vm%5Foperations%5Fg1.hpp)
src/hotspot/share/gc/g1/vm_operations_g1.hpp
rev 48252 : 8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME Summary: During a minor GC, if memory allocation fails, start a full GC within the same VM operation in the same safepoint. This avoids a race where the GC locker can prevent the full GC from occurring, and a premature OoME. Reviewed-by: Contributed-by: thomas.schatzl@oracle.com, axel.siebenborn@sap.com
11 lines changed: 0 ins; 11 del; 0 mod; 110 unchg
[Cdiffs](test/hotspot/jtreg/ProblemList.txt.cdiff.html) [Udiffs](test/hotspot/jtreg/ProblemList.txt.udiff.html) [Sdiffs](test/hotspot/jtreg/ProblemList.txt.sdiff.html) [Frames](test/hotspot/jtreg/ProblemList.txt.frames.html) [Old](test/hotspot/jtreg/ProblemList.txt-.html) [New](test/hotspot/jtreg/ProblemList.txt.html) [Patch](test/hotspot/jtreg/ProblemList.txt.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/ProblemList.txt)
test/hotspot/jtreg/ProblemList.txt
rev 48252 : 8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME Summary: During a minor GC, if memory allocation fails, start a full GC within the same VM operation in the same safepoint. This avoids a race where the GC locker can prevent the full GC from occurring, and a premature OoME. Reviewed-by: Contributed-by: thomas.schatzl@oracle.com, axel.siebenborn@sap.com
1 line changed: 1 ins; 0 del; 0 mod; 95 unchg
[Cdiffs](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.cdiff.html) [Udiffs](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.udiff.html) [Sdiffs](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.sdiff.html) [Frames](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.frames.html) [Old](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c-.html) [New](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.html) [Patch](test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c)
test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c
30 lines changed: 21 ins; 6 del; 3 mod; 255 unchg
------ ------ ------ ------ ---[New](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/TestJNIBlockFullGC.java.html) [Patch](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/TestJNIBlockFullGC.java.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/TestJNIBlockFullGC.java)
test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/TestJNIBlockFullGC.java
rev 48251 : imported patch 8137099-add-testcase
181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.html) [Patch](test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c.patch) [Raw](raw%5Ffiles/new/test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c)
test/hotspot/jtreg/gc/stress/TestJNIBlockFullGC/libTestJNIBlockFullGC.c
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using ../../../tools/webrev.sh(vers 25.6-hg+openjdk.java.net).