8006965 (original) (raw)

Code Review for 8006965

Prepared by: twisti on Wed Mar 20 16:55:03 PDT 2013
Workspace: /Users/twisti/ws/8006965
Compare against: http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot
Summary of changes: 547 lines changed: 35 ins; 502 del; 10 mod; 3231 unchg
Patch of changes: <8006965.patch>
Author comments: 8006965: remove test_gamma and add dedicated test_* targets insteadReviewed-by:Right now test_gamma runs with the boot JDK which is JDK n-1 (whereJDK n is the version we are actually compiling for). This setup isunsupported and thus should not be done during HotSpot builds.The fix is to always use JDK_IMPORT_PATH instead of JAVA_HOME whenrunning test_gamma.
Bug id: 8006965
Legend: Modified file Deleted file New file

[Cdiffs](make/Makefile.cdiff.html) [Udiffs](make/Makefile.udiff.html) [Sdiffs](make/Makefile.sdiff.html) [Frames](make/Makefile.frames.html) [Old](make/Makefile-.html) [New](make/Makefile.html) [Patch](make/Makefile.patch) [Raw](raw%5Ffiles/new/make/Makefile) make/Makefile

33 lines changed: 33 ins; 0 del; 0 mod; 721 unchg

[Cdiffs](make/bsd/Makefile.cdiff.html) [Udiffs](make/bsd/Makefile.udiff.html) [Sdiffs](make/bsd/Makefile.sdiff.html) [Frames](make/bsd/Makefile.frames.html) [Old](make/bsd/Makefile-.html) [New](make/bsd/Makefile.html) [Patch](make/bsd/Makefile.patch) [Raw](raw%5Ffiles/new/make/bsd/Makefile) make/bsd/Makefile

21 lines changed: 0 ins; 21 del; 0 mod; 389 unchg

[Cdiffs](make/bsd/makefiles/buildtree.make.cdiff.html) [Udiffs](make/bsd/makefiles/buildtree.make.udiff.html) [Sdiffs](make/bsd/makefiles/buildtree.make.sdiff.html) [Frames](make/bsd/makefiles/buildtree.make.frames.html) [Old](make/bsd/makefiles/buildtree.make-.html) [New](make/bsd/makefiles/buildtree.make.html) [Patch](make/bsd/makefiles/buildtree.make.patch) [Raw](raw%5Ffiles/new/make/bsd/makefiles/buildtree.make) make/bsd/makefiles/buildtree.make

121 lines changed: 0 ins; 118 del; 3 mod; 373 unchg

[Cdiffs](make/defs.make.cdiff.html) [Udiffs](make/defs.make.udiff.html) [Sdiffs](make/defs.make.sdiff.html) [Frames](make/defs.make.frames.html) [Old](make/defs.make-.html) [New](make/defs.make.html) [Patch](make/defs.make.patch) [Raw](raw%5Ffiles/new/make/defs.make) make/defs.make

4 lines changed: 0 ins; 3 del; 1 mod; 343 unchg

[Cdiffs](make/linux/Makefile.cdiff.html) [Udiffs](make/linux/Makefile.udiff.html) [Sdiffs](make/linux/Makefile.sdiff.html) [Frames](make/linux/Makefile.frames.html) [Old](make/linux/Makefile-.html) [New](make/linux/Makefile.html) [Patch](make/linux/Makefile.patch) [Raw](raw%5Ffiles/new/make/linux/Makefile) make/linux/Makefile

21 lines changed: 0 ins; 21 del; 0 mod; 392 unchg

[Cdiffs](make/linux/makefiles/buildtree.make.cdiff.html) [Udiffs](make/linux/makefiles/buildtree.make.udiff.html) [Sdiffs](make/linux/makefiles/buildtree.make.sdiff.html) [Frames](make/linux/makefiles/buildtree.make.frames.html) [Old](make/linux/makefiles/buildtree.make-.html) [New](make/linux/makefiles/buildtree.make.html) [Patch](make/linux/makefiles/buildtree.make.patch) [Raw](raw%5Ffiles/new/make/linux/makefiles/buildtree.make) make/linux/makefiles/buildtree.make

121 lines changed: 0 ins; 118 del; 3 mod; 366 unchg

[Cdiffs](make/solaris/Makefile.cdiff.html) [Udiffs](make/solaris/Makefile.udiff.html) [Sdiffs](make/solaris/Makefile.sdiff.html) [Frames](make/solaris/Makefile.frames.html) [Old](make/solaris/Makefile-.html) [New](make/solaris/Makefile.html) [Patch](make/solaris/Makefile.patch) [Raw](raw%5Ffiles/new/make/solaris/Makefile) make/solaris/Makefile

12 lines changed: 0 ins; 12 del; 0 mod; 292 unchg

[Cdiffs](make/solaris/makefiles/buildtree.make.cdiff.html) [Udiffs](make/solaris/makefiles/buildtree.make.udiff.html) [Sdiffs](make/solaris/makefiles/buildtree.make.sdiff.html) [Frames](make/solaris/makefiles/buildtree.make.frames.html) [Old](make/solaris/makefiles/buildtree.make-.html) [New](make/solaris/makefiles/buildtree.make.html) [Patch](make/solaris/makefiles/buildtree.make.patch) [Raw](raw%5Ffiles/new/make/solaris/makefiles/buildtree.make) make/solaris/makefiles/buildtree.make

128 lines changed: 2 ins; 123 del; 3 mod; 355 unchg

------ ------ ------ ------[Old](make/test/Queens.java-.html) ---[Patch](make/test/Queens.java.patch) --- make/test/Queens.java

86 lines changed: 0 ins; 86 del; 0 mod; 0 unchg


This code review page was prepared using /Users/twisti/bin/webrev(vers 23.18-hg-twisti).