jdk (original) (raw)

Code Review for jdk

Prepared by: valeriep on Thu Jan 3 16:30:06 PST 2013
Workspace: /net/glisten.us.oracle.com/export/home/vpeng/tlJDK8_4/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Summary of changes: 2089 lines changed: 1885 ins; 80 del; 124 mod; 5733 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/javax/crypto/Cipher.java.cdiff.html) [Udiffs](src/share/classes/javax/crypto/Cipher.java.udiff.html) [Sdiffs](src/share/classes/javax/crypto/Cipher.java.sdiff.html) [Frames](src/share/classes/javax/crypto/Cipher.java.frames.html) [Old](src/share/classes/javax/crypto/Cipher.java-.html) [New](src/share/classes/javax/crypto/Cipher.java.html) [Patch](src/share/classes/javax/crypto/Cipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/javax/crypto/Cipher.java) src/share/classes/javax/crypto/Cipher.java

6996769: support AEAD ciphers

18 lines changed: 13 ins; 0 del; 5 mod; 2670 unchg

[Cdiffs](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.cdiff.html) [Udiffs](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.udiff.html) [Sdiffs](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.sdiff.html) [Frames](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.frames.html) [Old](src/share/classes/javax/crypto/spec/GCMParameterSpec.java-.html) [New](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.html) [Patch](src/share/classes/javax/crypto/spec/GCMParameterSpec.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/javax/crypto/spec/GCMParameterSpec.java) src/share/classes/javax/crypto/spec/GCMParameterSpec.java

6996769: support AEAD ciphers

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

[Cdiffs](src/share/classes/com/sun/crypto/provider/AESCipher.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/AESCipher.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/AESCipher.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/AESCipher.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/AESCipher.java-.html) [New](src/share/classes/com/sun/crypto/provider/AESCipher.java.html) [Patch](src/share/classes/com/sun/crypto/provider/AESCipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/AESCipher.java) src/share/classes/com/sun/crypto/provider/AESCipher.java

6996769: support AEAD ciphers

92 lines changed: 91 ins; 0 del; 1 mod; 533 unchg

[Cdiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CipherCore.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CipherCore.java-.html) [New](src/share/classes/com/sun/crypto/provider/CipherCore.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CipherCore.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CipherCore.java) src/share/classes/com/sun/crypto/provider/CipherCore.java

6996769: support AEAD ciphers

375 lines changed: 252 ins; 55 del; 68 mod; 819 unchg

[Cdiffs](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java-.html) [New](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CipherTextStealing.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CipherTextStealing.java) src/share/classes/com/sun/crypto/provider/CipherTextStealing.java

6996769: support AEAD ciphers

9 lines changed: 4 ins; 0 del; 5 mod; 210 unchg

[Cdiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java-.html) [New](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.html) [Patch](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/FeedbackCipher.java) src/share/classes/com/sun/crypto/provider/FeedbackCipher.java

6996769: support AEAD ciphers

39 lines changed: 32 ins; 0 del; 7 mod; 192 unchg

[Cdiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/SunJCE.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/SunJCE.java-.html) [New](src/share/classes/com/sun/crypto/provider/SunJCE.java.html) [Patch](src/share/classes/com/sun/crypto/provider/SunJCE.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/SunJCE.java) src/share/classes/com/sun/crypto/provider/SunJCE.java

6996769: support AEAD ciphers

15 lines changed: 12 ins; 1 del; 2 mod; 755 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/crypto/provider/GCMParameters.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GCMParameters.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GCMParameters.java) src/share/classes/com/sun/crypto/provider/GCMParameters.java

6996769: support AEAD ciphers

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/crypto/provider/GCTR.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GCTR.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GCTR.java) src/share/classes/com/sun/crypto/provider/GCTR.java

6996769: support AEAD ciphers

144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/crypto/provider/GHASH.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GHASH.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GHASH.java) src/share/classes/com/sun/crypto/provider/GHASH.java

6996769: support AEAD ciphers

178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java) src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java

6996769: support AEAD ciphers

501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

[Cdiffs](test/javax/crypto/Cipher/GCMAPI.java.cdiff.html) [Udiffs](test/javax/crypto/Cipher/GCMAPI.java.udiff.html) [Sdiffs](test/javax/crypto/Cipher/GCMAPI.java.sdiff.html) [Frames](test/javax/crypto/Cipher/GCMAPI.java.frames.html) [Old](test/javax/crypto/Cipher/GCMAPI.java-.html) [New](test/javax/crypto/Cipher/GCMAPI.java.html) [Patch](test/javax/crypto/Cipher/GCMAPI.java.patch) [Raw](raw%5Ffiles/new/test/javax/crypto/Cipher/GCMAPI.java) test/javax/crypto/Cipher/GCMAPI.java

6996769: support AEAD ciphers

7 lines changed: 6 ins; 0 del; 1 mod; 137 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java-.html) [New](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/Test4512524.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/Test4512524.java) test/com/sun/crypto/provider/Cipher/AES/Test4512524.java

6996769: support AEAD ciphers

11 lines changed: 1 ins; 4 del; 6 mod; 67 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java-.html) [New](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/Test4512704.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/Test4512704.java) test/com/sun/crypto/provider/Cipher/AES/Test4512704.java

6996769: support AEAD ciphers

17 lines changed: 3 ins; 8 del; 6 mod; 61 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java-.html) [New](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/Test4517355.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/Test4517355.java) test/com/sun/crypto/provider/Cipher/AES/Test4517355.java

6996769: support AEAD ciphers

30 lines changed: 10 ins; 6 del; 14 mod; 80 unchg

[Cdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java-.html) [New](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/Test4626070.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/Test4626070.java) test/com/sun/crypto/provider/Cipher/AES/Test4626070.java

6996769: support AEAD ciphers

13 lines changed: 0 ins; 6 del; 7 mod; 62 unchg

------ ------ ------ ------ ---[New](test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java) test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java

6996769: support AEAD ciphers

314 lines changed: 314 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ---[New](test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java) test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java

6996769: support AEAD ciphers

178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg


This code review page was prepared using /home/vpeng/bin/HG/hgWebrev(vers 23.18-hg).