jdk (original) (raw)
Code Review for jdk
| Prepared by: | valeriep on Fri Jun 28 17:00:34 PDT 2013 |
|---|---|
| Workspace: | /net/glisten.us.oracle.com/export/home/vpeng/tlJDK8_New/jdk |
| Compare against: | http://hg.openjdk.java.net/jdk8/tl/jdk |
| Summary of changes: | 507 lines changed: 262 ins; 96 del; 149 mod; 4051 unchg |
| Patch of changes: | <jdk.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java-.html) [New](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java) src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
8012900: CICO ignores AAD in GCM mode
10 lines changed: 4 ins; 1 del; 5 mod; 206 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CipherCore.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CipherCore.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CipherCore.java-.html) [New](src/share/classes/com/sun/crypto/provider/CipherCore.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CipherCore.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CipherCore.java) src/share/classes/com/sun/crypto/provider/CipherCore.java
8012900: CICO ignores AAD in GCM mode
184 lines changed: 64 ins; 78 del; 42 mod; 1015 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CipherFeedback.java-.html) [New](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CipherFeedback.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CipherFeedback.java) src/share/classes/com/sun/crypto/provider/CipherFeedback.java
8012900: CICO ignores AAD in GCM mode
9 lines changed: 4 ins; 0 del; 5 mod; 267 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/CounterMode.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/CounterMode.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/CounterMode.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/CounterMode.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/CounterMode.java-.html) [New](src/share/classes/com/sun/crypto/provider/CounterMode.java.html) [Patch](src/share/classes/com/sun/crypto/provider/CounterMode.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/CounterMode.java) src/share/classes/com/sun/crypto/provider/CounterMode.java
8012900: CICO ignores AAD in GCM mode
10 lines changed: 4 ins; 0 del; 6 mod; 204 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java-.html) [New](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.html) [Patch](src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java) src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java
8012900: CICO ignores AAD in GCM mode
12 lines changed: 4 ins; 3 del; 5 mod; 152 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java-.html) [New](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.html) [Patch](src/share/classes/com/sun/crypto/provider/FeedbackCipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/FeedbackCipher.java) src/share/classes/com/sun/crypto/provider/FeedbackCipher.java
8012900: CICO ignores AAD in GCM mode
24 lines changed: 13 ins; 1 del; 10 mod; 220 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/GCTR.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/GCTR.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/GCTR.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/GCTR.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/GCTR.java-.html) [New](src/share/classes/com/sun/crypto/provider/GCTR.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GCTR.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GCTR.java) src/share/classes/com/sun/crypto/provider/GCTR.java
8012900: CICO ignores AAD in GCM mode
11 lines changed: 2 ins; 4 del; 5 mod; 135 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java-.html) [New](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.html) [Patch](src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java) src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
8012900: CICO ignores AAD in GCM mode
113 lines changed: 50 ins; 9 del; 54 mod; 438 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/OutputFeedback.java-.html) [New](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.html) [Patch](src/share/classes/com/sun/crypto/provider/OutputFeedback.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/OutputFeedback.java) src/share/classes/com/sun/crypto/provider/OutputFeedback.java
8012900: CICO ignores AAD in GCM mode
8 lines changed: 3 ins; 0 del; 5 mod; 224 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PCBC.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PCBC.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PCBC.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PCBC.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PCBC.java-.html) [New](src/share/classes/com/sun/crypto/provider/PCBC.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PCBC.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PCBC.java) src/share/classes/com/sun/crypto/provider/PCBC.java
8012900: CICO ignores AAD in GCM mode
6 lines changed: 2 ins; 0 del; 4 mod; 194 unchg
[Cdiffs](src/share/classes/javax/crypto/CipherSpi.java.cdiff.html) [Udiffs](src/share/classes/javax/crypto/CipherSpi.java.udiff.html) [Sdiffs](src/share/classes/javax/crypto/CipherSpi.java.sdiff.html) [Frames](src/share/classes/javax/crypto/CipherSpi.java.frames.html) [Old](src/share/classes/javax/crypto/CipherSpi.java-.html) [New](src/share/classes/javax/crypto/CipherSpi.java.html) [Patch](src/share/classes/javax/crypto/CipherSpi.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/javax/crypto/CipherSpi.java) src/share/classes/javax/crypto/CipherSpi.java
8012900: CICO ignores AAD in GCM mode
15 lines changed: 7 ins; 0 del; 8 mod; 996 unchg
------ ------ ------ ------ ---[New](test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java.html) [Patch](test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java) test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java
8012900: CICO ignores AAD in GCM mode
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /home/vpeng/bin/HG/hgWebrev(vers 23.18-hg).