jdk (original) (raw)
Code Review for jdk
| Prepared by: | vinnie on Fri Jun 1 19:00:49 BST 2012 |
|---|---|
| Workspace: | /export2/Users/vinnie/repos/jdk8-jep121/jdk |
| Compare against: | http://hg.openjdk.java.net/jdk8/jdk8/jdk |
| Summary of changes: | 1901 lines changed: 1771 ins; 34 del; 96 mod; 3319 unchg |
| Patch of changes: | <jdk.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBECipherCore.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBECipherCore.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBECipherCore.java) src/share/classes/com/sun/crypto/provider/PBECipherCore.java
115 lines changed: 84 ins; 10 del; 21 mod; 508 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java) src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java
103 lines changed: 103 ins; 0 del; 0 mod; 202 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java) src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java
1 line changed: 0 ins; 0 del; 1 mod; 428 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java) src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java
1 line changed: 0 ins; 0 del; 1 mod; 434 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java-.html) [New](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java) src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java
344 lines changed: 308 ins; 23 del; 13 mod; 493 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/SunJCE.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/SunJCE.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/SunJCE.java-.html) [New](src/share/classes/com/sun/crypto/provider/SunJCE.java.html) [Patch](src/share/classes/com/sun/crypto/provider/SunJCE.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/SunJCE.java) src/share/classes/com/sun/crypto/provider/SunJCE.java
230 lines changed: 220 ins; 1 del; 9 mod; 468 unchg
[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.html) [Patch](test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java) test/com/sun/crypto/provider/Cipher/PBE/PBEInvalidParamsTest.java
15 lines changed: 12 ins; 0 del; 3 mod; 64 unchg
[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.html) [Patch](test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java) test/com/sun/crypto/provider/Cipher/PBE/PBEKeysAlgorithmNames.java
10 lines changed: 7 ins; 0 del; 3 mod; 80 unchg
[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.html) [Patch](test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java) test/com/sun/crypto/provider/Cipher/PBE/PBEParametersTest.java
15 lines changed: 12 ins; 0 del; 3 mod; 59 unchg
[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.html) [Patch](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java) test/com/sun/crypto/provider/Cipher/PBE/PKCS12Cipher.java
5 lines changed: 3 ins; 0 del; 2 mod; 109 unchg
[Cdiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.frames.html) [Old](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java-.html) [New](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.html) [Patch](test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java) test/com/sun/crypto/provider/Cipher/PBE/PKCS12Oid.java
12 lines changed: 8 ins; 0 del; 4 mod; 44 unchg
[Cdiffs](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.frames.html) [Old](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java-.html) [New](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.html) [Patch](test/com/sun/crypto/provider/Mac/HmacPBESHA1.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Mac/HmacPBESHA1.java) test/com/sun/crypto/provider/Mac/HmacPBESHA1.java
22 lines changed: 10 ins; 0 del; 12 mod; 62 unchg
[Cdiffs](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.cdiff.html) [Udiffs](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.udiff.html) [Sdiffs](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.sdiff.html) [Frames](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.frames.html) [Old](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java-.html) [New](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.html) [Patch](test/com/sun/crypto/provider/Mac/HmacSaltLengths.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/crypto/provider/Mac/HmacSaltLengths.java) test/com/sun/crypto/provider/Mac/HmacSaltLengths.java
12 lines changed: 10 ins; 0 del; 2 mod; 104 unchg
------ ------ ------ ------ ---[New](src/share/classes/com/sun/crypto/provider/PBES2Core.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBES2Core.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBES2Core.java) src/share/classes/com/sun/crypto/provider/PBES2Core.java
927 lines changed: 927 ins; 0 del; 0 mod; 0 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBKDF2Core.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBKDF2Core.java) src/share/classes/com/sun/crypto/provider/PBKDF2Core.java (was src/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java)
41 lines changed: 30 ins; 0 del; 11 mod; 141 unchg
[Cdiffs](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.cdiff.html) [Udiffs](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.udiff.html) [Sdiffs](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.sdiff.html) [Frames](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.frames.html) [Old](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java-.html) [New](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.html) [Patch](src/share/classes/com/sun/crypto/provider/PBMAC1Core.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/crypto/provider/PBMAC1Core.java) src/share/classes/com/sun/crypto/provider/PBMAC1Core.java (was src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java)
48 lines changed: 37 ins; 0 del; 11 mod; 123 unchg
This code review page was prepared using /java/jdk/bin/webrev(vers 23.17-hg).