jdk (original) (raw)

Code Review for jdk

[Cdiffs](src/share/classes/java/lang/invoke/BoundMethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/BoundMethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/BoundMethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/BoundMethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/BoundMethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/BoundMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/BoundMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/BoundMethodHandle.java) src/share/classes/java/lang/invoke/BoundMethodHandle.java

rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

46 lines changed: 25 ins; 21 del; 0 mod; 798 unchg

[Cdiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/DirectMethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/DirectMethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/DirectMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/DirectMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/DirectMethodHandle.java) src/share/classes/java/lang/invoke/DirectMethodHandle.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

5 lines changed: 5 ins; 0 del; 0 mod; 691 unchg

[Cdiffs](src/share/classes/java/lang/invoke/LambdaForm.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/LambdaForm.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/LambdaForm.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/LambdaForm.java.frames.html) [Old](src/share/classes/java/lang/invoke/LambdaForm.java-.html) [New](src/share/classes/java/lang/invoke/LambdaForm.java.html) [Patch](src/share/classes/java/lang/invoke/LambdaForm.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/LambdaForm.java) src/share/classes/java/lang/invoke/LambdaForm.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10275 : imported patch invokers rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

5 lines changed: 5 ins; 0 del; 0 mod; 1842 unchg

[Cdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandle.java) src/share/classes/java/lang/invoke/MethodHandle.java

rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10278 : imported patch isInvokeSpecial rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

59 lines changed: 0 ins; 55 del; 4 mod; 1421 unchg

[Cdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandleImpl.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandleImpl.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandleImpl.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandleImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandleImpl.java) src/share/classes/java/lang/invoke/MethodHandleImpl.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10272 : 8038261: JSR292: cache and reuse typed array accessors Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10278 : imported patch isInvokeSpecial rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

61 lines changed: 14 ins; 39 del; 8 mod; 1249 unchg

[Cdiffs](src/share/classes/java/lang/invoke/MethodTypeForm.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodTypeForm.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodTypeForm.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodTypeForm.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodTypeForm.java-.html) [New](src/share/classes/java/lang/invoke/MethodTypeForm.java.html) [Patch](src/share/classes/java/lang/invoke/MethodTypeForm.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodTypeForm.java) src/share/classes/java/lang/invoke/MethodTypeForm.java

rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10275 : imported patch invokers rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

2 lines changed: 0 ins; 0 del; 2 mod; 409 unchg

[Cdiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/SimpleMethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/SimpleMethodHandle.java) src/share/classes/java/lang/invoke/SimpleMethodHandle.java

rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

59 lines changed: 56 ins; 0 del; 3 mod; 42 unchg

------ ------ ------ ------ ---[New](src/share/classes/java/lang/invoke/DelegatingMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/DelegatingMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/DelegatingMethodHandle.java) src/share/classes/java/lang/invoke/DelegatingMethodHandle.java

rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/vlivanov/bin/webrev(vers 23.18-hg-never-dev).