jdk (original) (raw)
Code Review for jdk
Prepared by: | vlivanov on Mon Jul 14 19:55:48 MSK 2014 |
---|---|
Workspace: | /Users/vlivanov/ws/jdk/ws/jdk9-dev/jdk |
Compare against: | http://hg.openjdk.java.net/jdk9/dev/jdk |
Compare against version: | arguments.remove |
Summary of changes: | 90 lines changed: 58 ins; 7 del; 25 mod; 7879 unchg |
Patch of changes: | <jdk.patch> |
Bug id: | Bug Database |
Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/java/lang/invoke/CallSite.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/CallSite.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/CallSite.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/CallSite.java.frames.html) [Old](src/share/classes/java/lang/invoke/CallSite.java-.html) [New](src/share/classes/java/lang/invoke/CallSite.java.html) [Patch](src/share/classes/java/lang/invoke/CallSite.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/CallSite.java)
src/share/classes/java/lang/invoke/CallSite.java
rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10275 : imported patch invokers rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
1 line changed: 0 ins; 0 del; 1 mod; 359 unchg
[Cdiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/DirectMethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/DirectMethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/DirectMethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/DirectMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/DirectMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/DirectMethodHandle.java)
src/share/classes/java/lang/invoke/DirectMethodHandle.java
rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
18 lines changed: 6 ins; 4 del; 8 mod; 677 unchg
[Cdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandle.java)
src/share/classes/java/lang/invoke/MethodHandle.java
rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
23 lines changed: 21 ins; 0 del; 2 mod; 1457 unchg
[Cdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandleImpl.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandleImpl.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandleImpl.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandleImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandleImpl.java)
src/share/classes/java/lang/invoke/MethodHandleImpl.java
rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10272 : 8038261: JSR292: cache and reuse typed array accessors Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
24 lines changed: 12 ins; 3 del; 9 mod; 1269 unchg
[Cdiffs](src/share/classes/java/lang/invoke/MethodHandles.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandles.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandles.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandles.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandles.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandles.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandles.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandles.java)
src/share/classes/java/lang/invoke/MethodHandles.java
rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10275 : imported patch invokers rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
4 lines changed: 3 ins; 0 del; 1 mod; 2921 unchg
[Cdiffs](src/share/classes/java/lang/invoke/MethodType.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodType.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodType.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodType.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodType.java-.html) [New](src/share/classes/java/lang/invoke/MethodType.java.html) [Patch](src/share/classes/java/lang/invoke/MethodType.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodType.java)
src/share/classes/java/lang/invoke/MethodType.java
rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
15 lines changed: 11 ins; 0 del; 4 mod; 1156 unchg
[Cdiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/SimpleMethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/SimpleMethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/SimpleMethodHandle.java)
src/share/classes/java/lang/invoke/SimpleMethodHandle.java
rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com
5 lines changed: 5 ins; 0 del; 0 mod; 40 unchg
This code review page was prepared using /Users/vlivanov/bin/webrev(vers 23.18-hg-never-dev).