jdk (original) (raw)

Code Review for jdk

Prepared by: vlivanov on Mon Jul 14 21:04:28 MSK 2014
Workspace: /Users/vlivanov/ws/jdk/ws/jdk9-dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version: reinvoker
Summary of changes: 204 lines changed: 118 ins; 65 del; 21 mod; 5882 unchg
Patch of changes: <jdk.patch>
Bug id: Bug Database
Legend: Modified file Deleted file New file

[Cdiffs](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.frames.html) [Old](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java-.html) [New](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.html) [Patch](src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java) src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10272 : 8038261: JSR292: cache and reuse typed array accessors Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10280 : 8050200: Make LambdaForm intrinsics detection more robust Reviewed-by: ?

111 lines changed: 40 ins; 56 del; 15 mod; 1354 unchg

[Cdiffs](src/share/classes/java/lang/invoke/LambdaForm.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/LambdaForm.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/LambdaForm.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/LambdaForm.java.frames.html) [Old](src/share/classes/java/lang/invoke/LambdaForm.java-.html) [New](src/share/classes/java/lang/invoke/LambdaForm.java.html) [Patch](src/share/classes/java/lang/invoke/LambdaForm.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/LambdaForm.java) src/share/classes/java/lang/invoke/LambdaForm.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10275 : imported patch invokers rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10280 : 8050200: Make LambdaForm intrinsics detection more robust Reviewed-by: ?

7 lines changed: 5 ins; 1 del; 1 mod; 1845 unchg

[Cdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandle.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandle.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandle.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandle.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandle.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandle.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandle.java) src/share/classes/java/lang/invoke/MethodHandle.java

rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10278 : 8050174: Support overriding of isInvokeSpecial flag in WrappedMember Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10280 : 8050200: Make LambdaForm intrinsics detection more robust Reviewed-by: ?

9 lines changed: 6 ins; 3 del; 0 mod; 1422 unchg

[Cdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.cdiff.html) [Udiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.udiff.html) [Sdiffs](src/share/classes/java/lang/invoke/MethodHandleImpl.java.sdiff.html) [Frames](src/share/classes/java/lang/invoke/MethodHandleImpl.java.frames.html) [Old](src/share/classes/java/lang/invoke/MethodHandleImpl.java-.html) [New](src/share/classes/java/lang/invoke/MethodHandleImpl.java.html) [Patch](src/share/classes/java/lang/invoke/MethodHandleImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/java/lang/invoke/MethodHandleImpl.java) src/share/classes/java/lang/invoke/MethodHandleImpl.java

rev 10271 : 8037209: Improvements and cleanups to bytecode assembly for lambda forms Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10272 : 8038261: JSR292: cache and reuse typed array accessors Reviewed-by: vlivanov, psandoz Contributed-by: john.r.rose@oracle.com rev 10273 : 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke Reviewed-by: ? rev 10274 : 8050052: Small cleanups in java.lang.invoke code Reviewed-by: ? rev 10276 : 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10277 : 8050173: Add j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10278 : 8050174: Support overriding of isInvokeSpecial flag in WrappedMember Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10279 : 8050057: Improve caching of MethodHandle reinvokers Reviewed-by: vlivanov, ? Contributed-by: john.r.rose@oracle.com rev 10280 : 8050200: Make LambdaForm intrinsics detection more robust Reviewed-by: ?

77 lines changed: 67 ins; 5 del; 5 mod; 1261 unchg


This code review page was prepared using /Users/vlivanov/bin/webrev(vers 23.18-hg-never-dev).