jdk (original) (raw)
Code Review for jdk
| Prepared by: | weijun on Mon Jun 13 19:49:20 CST 2011 |
|---|---|
| Workspace: | /home/more/space/work/tl8/jdk |
| Compare against version: | -2 |
| Summary of changes: | 160 lines changed: 130 ins; 1 del; 29 mod; 1051 unchg |
| Patch of changes: | <jdk.patch> |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/share/classes/com/sun/security/ntlm/Client.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/ntlm/Client.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/ntlm/Client.java.sdiff.html) [Frames](src/share/classes/com/sun/security/ntlm/Client.java.frames.html) [Old](src/share/classes/com/sun/security/ntlm/Client.java-.html) [New](src/share/classes/com/sun/security/ntlm/Client.java.html) [Patch](src/share/classes/com/sun/security/ntlm/Client.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/ntlm/Client.java) src/share/classes/com/sun/security/ntlm/Client.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
10 lines changed: 3 ins; 1 del; 6 mod; 205 unchg
[Cdiffs](src/share/classes/com/sun/security/ntlm/NTLMException.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/ntlm/NTLMException.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/ntlm/NTLMException.java.sdiff.html) [Frames](src/share/classes/com/sun/security/ntlm/NTLMException.java.frames.html) [Old](src/share/classes/com/sun/security/ntlm/NTLMException.java-.html) [New](src/share/classes/com/sun/security/ntlm/NTLMException.java.html) [Patch](src/share/classes/com/sun/security/ntlm/NTLMException.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/ntlm/NTLMException.java) src/share/classes/com/sun/security/ntlm/NTLMException.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
5 lines changed: 5 ins; 0 del; 0 mod; 88 unchg
[Cdiffs](src/share/classes/com/sun/security/ntlm/Server.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/ntlm/Server.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/ntlm/Server.java.sdiff.html) [Frames](src/share/classes/com/sun/security/ntlm/Server.java.frames.html) [Old](src/share/classes/com/sun/security/ntlm/Server.java-.html) [New](src/share/classes/com/sun/security/ntlm/Server.java.html) [Patch](src/share/classes/com/sun/security/ntlm/Server.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/ntlm/Server.java) src/share/classes/com/sun/security/ntlm/Server.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
12 lines changed: 3 ins; 0 del; 9 mod; 196 unchg
[Cdiffs](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.sdiff.html) [Frames](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.frames.html) [Old](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java-.html) [New](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.html) [Patch](src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java) src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
9 lines changed: 6 ins; 0 del; 3 mod; 116 unchg
[Cdiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.sdiff.html) [Frames](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.frames.html) [Old](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java-.html) [New](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.html) [Patch](src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java) src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
7 lines changed: 3 ins; 0 del; 4 mod; 227 unchg
[Cdiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.cdiff.html) [Udiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.udiff.html) [Sdiffs](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.sdiff.html) [Frames](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.frames.html) [Old](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java-.html) [New](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.html) [Patch](src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java.patch) [Raw](raw%5Ffiles/new/src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java) src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
13 lines changed: 6 ins; 0 del; 7 mod; 219 unchg
------ ------ ------ ------ ---[New](test/com/sun/security/sasl/ntlm/Conformance.java.html) [Patch](test/com/sun/security/sasl/ntlm/Conformance.java.patch) [Raw](raw%5Ffiles/new/test/com/sun/security/sasl/ntlm/Conformance.java) test/com/sun/security/sasl/ntlm/Conformance.java
rev 4254 : 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: nobody
104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /java/jdk/bin/webrev(vers 23.18-hg).