open (original) (raw)
Code Review for open
| Prepared by: | weijun on Mon Sep 18 17:03:17 CST 2017 |
|---|---|
| Workspace: | /space/repos/jdk10/master/open |
| Compare against version: | -2 |
| Summary of changes: | 1719 lines changed: 1661 ins; 16 del; 42 mod; 8544 unchg |
| Patch of changes: | <open.patch> (colored) |
| Legend: | Modified file Deleted file New file |
[Cdiffs](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.frames.html) [Old](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java-.html) [New](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.html) [Patch](src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java) src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
7 lines changed: 6 ins; 0 del; 1 mod; 247 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java-.html) [New](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java) src/java.security.jgss/share/classes/sun/security/jgss/krb5/CipherHelper.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
204 lines changed: 204 ins; 0 del; 0 mod; 1502 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java) src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
5 lines changed: 4 ins; 0 del; 1 mod; 342 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/Config.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/Config.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/Config.java) src/java.security.jgss/share/classes/sun/security/krb5/Config.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
14 lines changed: 12 ins; 0 del; 2 mod; 1388 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java) src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
7 lines changed: 6 ins; 0 del; 1 mod; 379 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java) src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
16 lines changed: 15 ins; 0 del; 1 mod; 582 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java) src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
2 lines changed: 2 ins; 0 del; 0 mod; 406 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
31 lines changed: 18 ins; 0 del; 13 mod; 357 unchg
[Cdiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.cdiff.html) [Udiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.udiff.html) [Sdiffs](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.sdiff.html) [Frames](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.frames.html) [Old](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java-.html) [New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
3 lines changed: 0 ins; 0 del; 3 mod; 695 unchg
[Cdiffs](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.cdiff.html) [Udiffs](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.udiff.html) [Sdiffs](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.sdiff.html) [Frames](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.frames.html) [Old](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java-.html) [New](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.html) [Patch](test/jdk/sun/security/krb5/auto/BasicKrb5Test.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/krb5/auto/BasicKrb5Test.java) test/jdk/sun/security/krb5/auto/BasicKrb5Test.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
20 lines changed: 8 ins; 2 del; 10 mod; 136 unchg
[Cdiffs](test/jdk/sun/security/krb5/auto/KDC.java.cdiff.html) [Udiffs](test/jdk/sun/security/krb5/auto/KDC.java.udiff.html) [Sdiffs](test/jdk/sun/security/krb5/auto/KDC.java.sdiff.html) [Frames](test/jdk/sun/security/krb5/auto/KDC.java.frames.html) [Old](test/jdk/sun/security/krb5/auto/KDC.java-.html) [New](test/jdk/sun/security/krb5/auto/KDC.java.html) [Patch](test/jdk/sun/security/krb5/auto/KDC.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/krb5/auto/KDC.java) test/jdk/sun/security/krb5/auto/KDC.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
36 lines changed: 17 ins; 13 del; 6 mod; 1949 unchg
[Cdiffs](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.cdiff.html) [Udiffs](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.udiff.html) [Sdiffs](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.sdiff.html) [Frames](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.frames.html) [Old](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java-.html) [New](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.html) [Patch](test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java) test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
9 lines changed: 6 ins; 1 del; 2 mod; 509 unchg
[Cdiffs](test/jdk/sun/security/krb5/etype/ETypeOrder.java.cdiff.html) [Udiffs](test/jdk/sun/security/krb5/etype/ETypeOrder.java.udiff.html) [Sdiffs](test/jdk/sun/security/krb5/etype/ETypeOrder.java.sdiff.html) [Frames](test/jdk/sun/security/krb5/etype/ETypeOrder.java.frames.html) [Old](test/jdk/sun/security/krb5/etype/ETypeOrder.java-.html) [New](test/jdk/sun/security/krb5/etype/ETypeOrder.java.html) [Patch](test/jdk/sun/security/krb5/etype/ETypeOrder.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/krb5/etype/ETypeOrder.java) test/jdk/sun/security/krb5/etype/ETypeOrder.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
2 lines changed: 0 ins; 0 del; 2 mod; 52 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128CtsHmacSha2EType.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128CtsHmacSha2EType.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128CtsHmacSha2EType.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128CtsHmacSha2EType.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128Sha2.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128Sha2.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128Sha2.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes128Sha2.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256CtsHmacSha2EType.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256CtsHmacSha2EType.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256CtsHmacSha2EType.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256CtsHmacSha2EType.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256Sha2.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256Sha2.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256Sha2.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Aes256Sha2.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes128CksumType.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes128CksumType.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes128CksumType.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes128CksumType.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes256CksumType.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes256CksumType.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes256CksumType.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/HmacSha2Aes256CksumType.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesSha2DkCrypto.java.html) [Patch](src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesSha2DkCrypto.java.patch) [Raw](raw%5Ffiles/new/src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesSha2DkCrypto.java) src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesSha2DkCrypto.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
541 lines changed: 541 ins; 0 del; 0 mod; 0 unchg
------ ------ ------ ------ ---[New](test/jdk/sun/security/krb5/etype/KerberosAesSha2.java.html) [Patch](test/jdk/sun/security/krb5/etype/KerberosAesSha2.java.patch) [Raw](raw%5Ffiles/new/test/jdk/sun/security/krb5/etype/KerberosAesSha2.java) test/jdk/sun/security/krb5/etype/KerberosAesSha2.java
rev 47226 : 8014628: Support AES Encryption with HMAC-SHA2 for Kerberos 5
209 lines changed: 209 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /space/repos/code-tools/webrev/webrev.ksh(vers 25.16-hg+openjdk.java.net).