jdk (original) (raw)

Code Review for jdk

Prepared by: weijun on Sun Jun 9 09:25:59 CST 2013
Workspace: /Users/more/space/repos/jdk8/tl/jdk
Compare against version: -2
Summary of changes: 111 lines changed: 62 ins; 12 del; 37 mod; 733 unchg
Patch of changes: <jdk.patch>
Legend: Modified file Deleted file New file

[Cdiffs](test/sun/security/tools/policytool/Alias.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/Alias.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/Alias.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/Alias.sh.frames.html) [Old](test/sun/security/tools/policytool/Alias.sh-.html) [New](test/sun/security/tools/policytool/Alias.sh.html) [Patch](test/sun/security/tools/policytool/Alias.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/Alias.sh) test/sun/security/tools/policytool/Alias.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 73 unchg

[Cdiffs](test/sun/security/tools/policytool/ChangeUI.html.cdiff.html) [Udiffs](test/sun/security/tools/policytool/ChangeUI.html.udiff.html) [Sdiffs](test/sun/security/tools/policytool/ChangeUI.html.sdiff.html) [Frames](test/sun/security/tools/policytool/ChangeUI.html.frames.html) [Old](test/sun/security/tools/policytool/ChangeUI.html-.html) [New](test/sun/security/tools/policytool/ChangeUI.html.html) [Patch](test/sun/security/tools/policytool/ChangeUI.html.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/ChangeUI.html) test/sun/security/tools/policytool/ChangeUI.html

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 1 ins; 0 del; 4 mod; 80 unchg

[Cdiffs](test/sun/security/tools/policytool/ChangeUI.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/ChangeUI.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/ChangeUI.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/ChangeUI.sh.frames.html) [Old](test/sun/security/tools/policytool/ChangeUI.sh-.html) [New](test/sun/security/tools/policytool/ChangeUI.sh.html) [Patch](test/sun/security/tools/policytool/ChangeUI.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/ChangeUI.sh) test/sun/security/tools/policytool/ChangeUI.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 72 unchg

[Cdiffs](test/sun/security/tools/policytool/OpenPolicy.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/OpenPolicy.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/OpenPolicy.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/OpenPolicy.sh.frames.html) [Old](test/sun/security/tools/policytool/OpenPolicy.sh-.html) [New](test/sun/security/tools/policytool/OpenPolicy.sh.html) [Patch](test/sun/security/tools/policytool/OpenPolicy.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/OpenPolicy.sh) test/sun/security/tools/policytool/OpenPolicy.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 72 unchg

[Cdiffs](test/sun/security/tools/policytool/SaveAs.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/SaveAs.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/SaveAs.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/SaveAs.sh.frames.html) [Old](test/sun/security/tools/policytool/SaveAs.sh-.html) [New](test/sun/security/tools/policytool/SaveAs.sh.html) [Patch](test/sun/security/tools/policytool/SaveAs.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/SaveAs.sh) test/sun/security/tools/policytool/SaveAs.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 73 unchg

[Cdiffs](test/sun/security/tools/policytool/UpdatePermissions.html.cdiff.html) [Udiffs](test/sun/security/tools/policytool/UpdatePermissions.html.udiff.html) [Sdiffs](test/sun/security/tools/policytool/UpdatePermissions.html.sdiff.html) [Frames](test/sun/security/tools/policytool/UpdatePermissions.html.frames.html) [Old](test/sun/security/tools/policytool/UpdatePermissions.html-.html) [New](test/sun/security/tools/policytool/UpdatePermissions.html.html) [Patch](test/sun/security/tools/policytool/UpdatePermissions.html.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/UpdatePermissions.html) test/sun/security/tools/policytool/UpdatePermissions.html

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

11 lines changed: 1 ins; 4 del; 6 mod; 52 unchg

[Cdiffs](test/sun/security/tools/policytool/UpdatePermissions.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/UpdatePermissions.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/UpdatePermissions.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/UpdatePermissions.sh.frames.html) [Old](test/sun/security/tools/policytool/UpdatePermissions.sh-.html) [New](test/sun/security/tools/policytool/UpdatePermissions.sh.html) [Patch](test/sun/security/tools/policytool/UpdatePermissions.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/UpdatePermissions.sh) test/sun/security/tools/policytool/UpdatePermissions.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 72 unchg

[Cdiffs](test/sun/security/tools/policytool/UsePolicy.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/UsePolicy.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/UsePolicy.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/UsePolicy.sh.frames.html) [Old](test/sun/security/tools/policytool/UsePolicy.sh-.html) [New](test/sun/security/tools/policytool/UsePolicy.sh.html) [Patch](test/sun/security/tools/policytool/UsePolicy.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/UsePolicy.sh) test/sun/security/tools/policytool/UsePolicy.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

5 lines changed: 5 ins; 0 del; 0 mod; 72 unchg

[Cdiffs](test/sun/security/tools/policytool/i18n.html.cdiff.html) [Udiffs](test/sun/security/tools/policytool/i18n.html.udiff.html) [Sdiffs](test/sun/security/tools/policytool/i18n.html.sdiff.html) [Frames](test/sun/security/tools/policytool/i18n.html.frames.html) [Old](test/sun/security/tools/policytool/i18n.html-.html) [New](test/sun/security/tools/policytool/i18n.html.html) [Patch](test/sun/security/tools/policytool/i18n.html.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/i18n.html) test/sun/security/tools/policytool/i18n.html

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

47 lines changed: 13 ins; 8 del; 26 mod; 96 unchg

[Cdiffs](test/sun/security/tools/policytool/i18n.sh.cdiff.html) [Udiffs](test/sun/security/tools/policytool/i18n.sh.udiff.html) [Sdiffs](test/sun/security/tools/policytool/i18n.sh.sdiff.html) [Frames](test/sun/security/tools/policytool/i18n.sh.frames.html) [Old](test/sun/security/tools/policytool/i18n.sh-.html) [New](test/sun/security/tools/policytool/i18n.sh.html) [Patch](test/sun/security/tools/policytool/i18n.sh.patch) [Raw](raw%5Ffiles/new/test/sun/security/tools/policytool/i18n.sh) test/sun/security/tools/policytool/i18n.sh

rev 7285 : 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case

18 lines changed: 17 ins; 0 del; 1 mod; 71 unchg


This code review page was prepared using /space/repos/jdk8/tl/make/scripts/webrev.ksh(vers 24.0-hg+jbs).