Improper Control of Generation of Code ('Code Injection') (4.19.1) (original) (raw)
| CWE Glossary Definition | ![]() |
|---|---|
Weakness ID: 94
Vulnerability Mapping: ALLOWED This CWE ID could be used to map to real-world vulnerabilities in limited situations requiring careful review (with careful review of mapping notes)
Abstraction:Base Base - a weakness that is still mostly independent of a resource or technology, but with sufficient details to provide specific methods for detection and prevention. Base level weaknesses typically describe issues in terms of 2 or 3 of the following dimensions: behavior, property, technology, language, and resource.
This table specifies different individual consequences associated with the weakness. The Scope identifies the application security area that is violated, while the Impact describes the negative technical impact that arises if an adversary succeeds in exploiting this weakness. The Likelihood provides information about how likely the specific consequence is expected to be seen relative to the other consequences in the list. For example, there may be high likelihood that a weakness will be exploited to achieve a certain impact, but a low likelihood that it will be exploited to achieve a different impact.
| Impact | Details |
|---|---|
| Bypass Protection Mechanism | Scope: Access Control In some cases, injectable code controls authentication; this may lead to a remote vulnerability. |
| Gain Privileges or Assume Identity | Scope: Access Control Injected code can access resources that the attacker is directly prevented from accessing. |
| Execute Unauthorized Code or Commands | Scope: Integrity, Confidentiality, Availability When a product allows a user's input to contain code syntax, it might be possible for an attacker to craft the code in such a way that it will alter the intended control flow of the product. As a result, code injection can often result in the execution of arbitrary code. Code injection attacks can also lead to loss of data integrity in nearly all cases, since the control-plane data injected is always incidental to data recall or writing. |
| Hide Activities | Scope: Non-Repudiation Often the actions performed by injected control code are unlogged. |
| Phase(s) | Mitigation |
|---|---|
| Architecture and Design | Refactor your program so that you do not have to dynamically generate code. |
| Architecture and Design | Run your code in a "jail" or similar sandbox environment that enforces strict boundaries between the process and the operating system. This may effectively restrict which code can be executed by your product. Examples include the Unix chroot jail and AppArmor. In general, managed code may provide some protection. This may not be a feasible solution, and it only limits the impact to the operating system; the rest of your application may still be subject to compromise. Be careful to avoid CWE-243 and other weaknesses related to jails. |
| Implementation | Strategy: Input Validation Assume all input is malicious. Use an "accept known good" input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does. When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, "boat" may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as "red" or "blue." Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code's environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright. To reduce the likelihood of code injection, use stringent allowlists that limit which constructs are allowed. If you are dynamically constructing code that invokes a function, then verifying that the input is alphanumeric might be insufficient. An attacker might still be able to reference a dangerous function that you did not intend to allow, such as system(), exec(), or exit(). |
| Testing | Use automated static analysis tools that target this type of weakness. Many modern techniques use data flow analysis to minimize the number of false positives. This is not a perfect solution, since 100% accuracy and coverage are not feasible. |
| Testing | Use dynamic tools and techniques that interact with the product using large test suites with many diverse inputs, such as fuzz testing (fuzzing), robustness testing, and fault injection. The product's operation may slow down, but it should not become unstable, crash, or generate incorrect results. |
| Operation | Strategy: Compilation or Build Hardening Run the code in an environment that performs automatic taint propagation and prevents any command execution that uses tainted variables, such as Perl's "-T" switch. This will force the program to perform validation steps that remove the taint, although you must be careful to correctly validate your inputs so that you do not accidentally mark dangerous inputs as untainted (see CWE-183 and CWE-184). |
| Operation | Strategy: Environment Hardening Run the code in an environment that performs automatic taint propagation and prevents any command execution that uses tainted variables, such as Perl's "-T" switch. This will force the program to perform validation steps that remove the taint, although you must be careful to correctly validate your inputs so that you do not accidentally mark dangerous inputs as untainted (see CWE-183 and CWE-184). |
| Implementation | For Python programs, it is frequently encouraged to use the ast.literal_eval() function instead of eval, since it is intentionally designed to avoid executing code. However, an adversary could still cause excessive memory or stack consumption via deeply nested structures [REF-1372], so the python documentation discourages use of ast.literal_eval() on untrusted data [REF-1373]. Effectiveness: Discouraged Common Practice |
This table shows the weaknesses and high level categories that are related to this weakness. These relationships are defined as ChildOf, ParentOf, MemberOf and give insight to similar items that may exist at higher and lower levels of abstraction. In addition, relationships such as PeerOf and CanAlsoBe are defined to show similar weaknesses that the user may want to explore.
Relevant to the view "Research Concepts" (View-1000)
| Nature | Type | ID | Name |
|---|---|---|---|
| ChildOf | 74 | Improper Neutralization of Special Elements in Output Used by a Downstream Component ('Injection') | |
| ChildOf | 913 | Improper Control of Dynamically-Managed Code Resources | |
| ParentOf | 95 | Improper Neutralization of Directives in Dynamically Evaluated Code ('Eval Injection') | |
| ParentOf | 96 | Improper Neutralization of Directives in Statically Saved Code ('Static Code Injection') | |
| ParentOf | 1336 | Improper Neutralization of Special Elements Used in a Template Engine | |
| CanFollow | 98 | Improper Control of Filename for Include/Require Statement in PHP Program ('PHP Remote File Inclusion') |
Relevant to the view "Software Development" (View-699)
| Nature | Type | ID | Name |
|---|---|---|---|
| MemberOf | 137 | Data Neutralization Issues |
Relevant to the view "Weaknesses for Simplified Mapping of Published Vulnerabilities" (View-1003)
| Nature | Type | ID | Name |
|---|---|---|---|
| ChildOf | 74 | Improper Neutralization of Special Elements in Output Used by a Downstream Component ('Injection') |
Relevant to the view "Architectural Concepts" (View-1008)
| Nature | Type | ID | Name |
|---|---|---|---|
| MemberOf | 1019 | Validate Inputs |
The different Modes of Introduction provide information about how and when this weakness may be introduced. The Phase identifies a point in the life cycle at which introduction may occur, while the Note provides a typical scenario related to introduction during the given phase.
| Phase | Note |
|---|---|
| Implementation | REALIZATION: This weakness is caused during implementation of an architectural security tactic. |
This listing shows possible areas for which the given weakness could appear. These may be for specific named Languages, Operating Systems, Architectures, Paradigms, Technologies, or a class of such platforms. The platform is listed along with how frequently the given weakness appears for that instance.
| Languages | Class: Interpreted(Sometimes Prevalent) |
|---|---|
| Technologies | AI/ML(Undetermined Prevalence) |
Example 1
This example attempts to write user messages to a message file and allow users to view them.
(bad code)
Example Language: PHP
$MessageFile = "messages.out";
if ($_GET["action"] == "NewMessage") {
name=name = name=_GET["name"]; message=message = message=_GET["message"]; handle=fopen(handle = fopen(handle=fopen(MessageFile, "a+");
fwrite($handle, "$name says '$message'
\n");
fclose($handle);
echo "Message Saved!
\n";
}
else if ($_GET["action"] == "ViewMessages") {
include($MessageFile);
}
While the programmer intends for the MessageFile to only include data, an attacker can provide a message such as:
name=h4x0r
message=%3C?php%20system(%22/bin/ls%20-l%22);?%3E
which will decode to the following:
The programmer thought they were just including the contents of a regular data file, but PHP parsed it and executed the code. Now, this code is executed any time people view messages.
Notice that XSS (CWE-79) is also possible in this situation.
Example 2
edit-config.pl: This CGI script is used to modify settings in a configuration file.
(bad code)
Example Language: Perl
use CGI qw(:standard);
sub config_file_add_key {
my ($fname, key,key, key,arg) = @_;
# code to add a field/key to a file goes here
}
sub config_file_set_key {
my ($fname, key,key, key,arg) = @_;
# code to set key to a particular file goes here
}
sub config_file_delete_key {
my ($fname, key,key, key,arg) = @_;
# code to delete key from a particular file goes here
}
sub handleConfigAction {
my ($fname, $action) = @_;
my $key = param('key');
my $val = param('val');
# this is super-efficient code, especially if you have to invoke
# any one of dozens of different functions!
my code="configfilecode = "config_file_code="configfileaction_key(\$fname, \$key, \$val);";
eval($code);
}
$configfile = "/home/cwe/config.txt";
print header;
if (defined(param('action'))) {
handleConfigAction($configfile, param('action'));
}
else {
print "No action specified!\n";
}
The script intends to take the 'action' parameter and invoke one of a variety of functions based on the value of that parameter - config_file_add_key(), config_file_set_key(), or config_file_delete_key(). It could set up a conditional to invoke each function separately, but eval() is a powerful way of doing the same thing in fewer lines of code, especially when a large number of functions or variables are involved. Unfortunately, in this case, the attacker can provide other values in the action parameter, such as:
add_key(",","); system("/bin/ls");
This would produce the following string in handleConfigAction():
config_file_add_key(",","); system("/bin/ls");
Any arbitrary Perl code could be added after the attacker has "closed off" the construction of the original function call, in order to prevent parsing errors from causing the malicious eval() to fail before the attacker's payload is activated. This particular manipulation would fail after the system() call, because the "_key(\$fname, \$key, \$val)" portion of the string would cause an error, but this is irrelevant to the attack because the payload has already been activated.
Example 3
This simple python3 script asks a user to supply a comma-separated list of numbers as input and adds them together.
(bad code)
Example Language: Python
def main():
sum = 0
try:
numbers = eval(input("Enter a comma-separated list of numbers: "))
except SyntaxError:
print("Error: invalid input")
return
for num in numbers:
sum = sum + num
print(f"Sum of {numbers} = {sum}")
main()
The eval() function can take the user-supplied list and convert it into a Python list object, therefore allowing the programmer to use list comprehension methods to work with the data. However, if code is supplied to the eval() function, it will execute that code. For example, a malicious user could supply the following string:
__import__('subprocess').getoutput('rm -r *')
This would delete all the files in the current directory. For this reason, it is not recommended to use eval() with untrusted input.
A way to accomplish this without the use of eval() is to apply an integer conversion on the input within a try/except block. If the user-supplied input is not numeric, this will raise a ValueError. By avoiding eval(), there is no opportunity for the input string to be executed as code.
(good code)
Example Language: Python
def main():
sum = 0
numbers = input("Enter a comma-separated list of numbers: ").split(",")
try:
for num in numbers:
sum = sum + int(num)
print(f"Sum of {numbers} = {sum}")
except ValueError:
print("Error: invalid input")
main()
An alternative, commonly-cited mitigation for this kind of weakness is to use the ast.literal_eval() function, since it is intentionally designed to avoid executing code. However, an adversary could still cause excessive memory or stack consumption via deeply nested structures [REF-1372], so the python documentation discourages use of ast.literal_eval() on untrusted data [REF-1373].
Example 4
The following code is a workflow job written using YAML. The code attempts to download pull request artifacts, unzip from the artifact called pr.zip and extract the value of the file NR into a variable "pr_number" that will be used later in another job. It attempts to create a github workflow environment variable, writing to $GITHUB_ENV. The environment variable value is retrieved from an external resource.
(bad code)
Example Language: Other
name: Deploy Preview
jobs:
deploy:
runs-on: ubuntu-latest
steps:
- name: 'Download artifact'
uses: actions/github-script
with:
script: |
var artifacts = await github.actions.listWorkflowRunArtifacts({
owner: context.repo.owner,
repo: context.repo.repo,
run_id: ${{ github.event.workflow_run.id }},
});
var matchPrArtifact = artifacts.data.artifacts.filter((artifact) => {
return artifact.name == "pr"
})[0];
var downloadPr = await github.actions.downloadArtifact({
owner: context.repo.owner,
repo: context.repo.repo,
artifact_id: matchPrArtifact.id,
archive_format: 'zip',
});
var fs = require('fs');
fs.writeFileSync('${{github.workspace}}/pr.zip', Buffer.from(downloadPr.data));
- run: |
unzip pr.zip
echo "pr_number=$(cat NR)" >> $GITHUB_ENV
The code does not neutralize the value of the file NR, e.g. by validating that NR only contains a number (CWE-1284). The NR file is attacker controlled because it originates from a pull request that produced pr.zip.
The attacker could escape the existing pr_number and create a new variable using a "\n" (CWE-93) followed by any environment variable to be added such as:
\nNODE_OPTIONS="--experimental-modules --experiments-loader=data:text/javascript,console.log('injected code');//"
This would result in injecting and running javascript code (CWE-94) on the workflow runner with elevated privileges.
(good code)
Example Language: Other
The code could be modified to validate that the NR file only contains a numeric value, or the code could retrieve the PR number from a more trusted source.
Note: this is a curated list of examples for users to understand the variety of ways in which this weakness can be introduced. It is not a complete list of all CVEs that are related to this CWE entry.
| Reference | Description |
|---|---|
| CVE-2023-29374 | Math component in an LLM framework translates user input into a Python expression that is input into the Python exec() method, allowing code execution - one variant of a "prompt injection" attack. |
| CVE-2024-5565 | Python-based library uses an LLM prompt containing user input to dynamically generate code that is then fed as input into the Python exec() method, allowing code execution - one variant of a "prompt injection" attack. |
| CVE-2024-4181 | Framework for LLM applications allows eval injection via a crafted response from a hosting provider. |
| CVE-2022-2054 | Python compiler uses eval() to execute malicious strings as Python code. |
| CVE-2021-22204 | Chain: regex in EXIF processor code does not correctly determine where a string ends (CWE-625), enabling eval injection (CWE-95), as exploited in the wild per CISA KEV. |
| CVE-2020-8218 | "Code injection" in VPN product, as exploited in the wild per CISA KEV. |
| CVE-2008-5071 | Eval injection in PHP program. |
| CVE-2002-1750 | Eval injection in Perl program. |
| CVE-2008-5305 | Eval injection in Perl program using an ID that should only contain hyphens and numbers. |
| CVE-2002-1752 | Direct code injection into Perl eval function. |
| CVE-2002-1753 | Eval injection in Perl program. |
| CVE-2005-1527 | Direct code injection into Perl eval function. |
| CVE-2005-2837 | Direct code injection into Perl eval function. |
| CVE-2005-1921 | MFV. code injection into PHP eval statement using nested constructs that should not be nested. |
| CVE-2005-2498 | MFV. code injection into PHP eval statement using nested constructs that should not be nested. |
| CVE-2005-3302 | Code injection into Python eval statement from a field in a formatted file. |
| CVE-2007-1253 | Eval injection in Python program. |
| CVE-2001-1471 | chain: Resultant eval injection. An invalid value prevents initialization of variables, which can be modified by attacker and later injected into PHP eval statement. |
| CVE-2002-0495 | Perl code directly injected into CGI library file from parameters to another CGI program. |
| CVE-2005-1876 | Direct PHP code injection into supporting template file. |
| CVE-2005-1894 | Direct code injection into PHP script that can be accessed by attacker. |
| CVE-2003-0395 | PHP code from User-Agent HTTP header directly inserted into log file implemented as PHP script. |
| Ordinality | Description |
|---|---|
| Primary | (where the weakness exists independent of other weaknesses) |
| Resultant | (where the weakness is typically related to the presence of some other weaknesses) |
| Method | Details |
|---|---|
| Automated Static Analysis | Automated static analysis, commonly referred to as Static Application Security Testing (SAST), can find some instances of this weakness by analyzing source code (or binary/compiled code) without having to execute it. Typically, this is done by building a model of data flow and control flow, then searching for potentially-vulnerable patterns that connect "sources" (origins of input) with "sinks" (destinations where the data interacts with external components, a lower layer such as the OS, etc.) Effectiveness: High |
This MemberOf Relationships table shows additional CWE Categories and Views that reference this weakness as a member. This information is often useful in understanding where a weakness fits within the context of external information sources.
| Usage | ALLOWED-WITH-REVIEW (this CWE ID could be used to map to real-world vulnerabilities in limited situations requiring careful review) |
|---|---|
| Reasons | Frequent Misuse, Frequent Misinterpretation |
| Rationale | This entry is frequently misused for vulnerabilities with a technical impact of "code execution," which does not by itself indicate a root cause weakness, since dozens of weaknesses can enable code execution. |
| Comments | This weakness only applies when the product's functionality intentionally constructs all or part of a code segment. It could be that executing code could be the result of other weaknesses that do not involve the construction of code segments. |
Theoretical
Injection problems encompass a wide variety of issues -- all mitigated in very different ways. For this reason, the most effective way to discuss these weaknesses is to note the distinct features that classify them as injection weaknesses. The most important issue to note is that all injection problems share one thing in common -- i.e., they allow for the injection of control plane data into the user-controlled data plane. This means that the execution of the process may be altered by sending code in through legitimate data channels, using no other mechanism. While buffer overflows, and many other flaws, involve the use of some further issue to gain execution, injection problems need only for the data to be parsed. The most classic instantiations of this category of weakness are SQL injection and format string vulnerabilities.
| Mapped Taxonomy Name | Node ID | Fit | Mapped Node Name |
|---|---|---|---|
| PLOVER | CODE | Code Evaluation and Injection | |
| ISA/IEC 62443 | Part 4-2 | Req CR 3.5 | |
| ISA/IEC 62443 | Part 3-3 | Req SR 3.5 | |
| ISA/IEC 62443 | Part 4-1 | Req SVV-1 | |
| ISA/IEC 62443 | Part 4-1 | Req SVV-3 |
More information is available — Please edit the custom filter or select a different filter.

