Steven Bosscher - Re: [PATCH] Use C99 isfinite macro instead of finite when available (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Steven Bosscher
• To: "John David Anglin" ,gcc-patches at gcc dot gnu dot org
• Cc: fortran at gcc dot gnu dot org
• Date: Mon, 23 Aug 2004 15:53:26 +0200
• Subject: Re: [PATCH] Use C99 isfinite macro instead of finite when available
• Organization: SUSE Labs
• References: <200408141920.i7EJKgwl003623@hiauly1.hia.nrc.ca>

On Saturday 14 August 2004 21:20, John David Anglin wrote:

This fixes a bunch of gfortran failures under HP-UX 11.x which doesn't have the finite function, only the isfinite macro.

Tested on hppa2.0w-hp-hpux11.11.

Ok for main?

Sorry for not following up more quickly (thanks Tobi ;-)

About your change,

    * io/write.c (write_float): Use isfinite macro when available.

I wonder if this should be a configure check, I'm no fan of rogue #ifdefs in the library. According to my man pages, isfinite is C99, and finite comes from BSD, so I suppose we should prefer isfinite, so at least that's correct.

libstdc++ has FINITE_P and GLIBCXX_ENABLE_C99. I suppose we need something like that for libgfortran too... If you have time, that'd be much appreciated. Otherwise I'll take care of it next weekend.

Gr. Steven

• Follow-Ups:
  • Re: [PATCH] Use C99 isfinite macro instead of finite when available
    * From: Paul Brook
  • Re: [PATCH] Use C99 isfinite macro instead of finite when availab
    * From: John David Anglin
• References:
  • [PATCH] Use C99 isfinite macro instead of finite when available
    * From: John David Anglin