cpython: 2502843dbedf (original) (raw)

Mercurial > cpython

changeset 90494:2502843dbedf

Issue #18727: improve test coverage of the csv module by testing for DictWriter.writerows. Patch by Muhammad Jehanzeb. [#18727]

Antoine Pitrou solipsis@pitrou.net
date	Tue, 29 Apr 2014 01:58:06 +0200
parents	d1a03834cec7
children	3b203f000256
files	Lib/test/test_csv.py Misc/ACKS
diffstat	2 files changed, 11 insertions(+), 0 deletions(-)[+] [-] Lib/test/test_csv.py 10 Misc/ACKS 1

line wrap: on

line diff

--- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -575,6 +575,16 @@ class TestDictFields(unittest.TestCase): fileobj.readline() # header self.assertEqual(fileobj.read(), "10,,abc\r\n")

def test_write_multiple_dict_rows(self):
```
   fileobj = StringIO()[](#l1.8)
```

   writer = csv.DictWriter(fileobj, fieldnames=["f1", "f2", "f3"])[](#l1.9)

```
   writer.writeheader()[](#l1.10)
```

   self.assertEqual(fileobj.getvalue(), "f1,f2,f3\r\n")[](#l1.11)

   writer.writerows([{"f1": 1, "f2": "abc", "f3": "f"},[](#l1.12)

                     {"f1": 2, "f2": 5, "f3": "xyz"}])[](#l1.13)

   self.assertEqual(fileobj.getvalue(),[](#l1.14)

                    "f1,f2,f3\r\n1,abc,f\r\n2,5,xyz\r\n")[](#l1.15)

+ def test_write_no_fields(self): fileobj = StringIO() self.assertRaises(TypeError, csv.DictWriter, fileobj)

--- a/Misc/ACKS +++ b/Misc/ACKS @@ -613,6 +613,7 @@ Juhana Jauhiainen Rajagopalasarma Jayakrishnan Zbigniew Jędrzejewski-Szmek Julien Jehannet +Muhammad Jehanzeb Drew Jenkins Flemming Kjær Jensen Philip H. Jensen