(original) (raw)

changeset: 75773:25b71858cb14 parent: 75770:561fc3b4cc2a user: Benjamin Peterson benjamin@python.org date: Sat Mar 17 00:05:44 2012 -0500 files: Lib/test/test_descr.py Misc/NEWS Objects/typeobject.c description: make extra arguments to object.__init__/__new__ to errors in most cases (finishes #1683368) diff -r 561fc3b4cc2a -r 25b71858cb14 Lib/test/test_descr.py --- a/Lib/test/test_descr.py Fri Mar 16 22:46:14 2012 -0400 +++ b/Lib/test/test_descr.py Sat Mar 17 00:05:44 2012 -0500 @@ -4502,6 +4502,26 @@ for o in gc.get_objects(): self.assertIsNot(type(o), X) + def test_object_new_and_init_with_parameters(self): + # See issue #1683368 + class OverrideNeither: + pass + self.assertRaises(TypeError, OverrideNeither, 1) + self.assertRaises(TypeError, OverrideNeither, kw=1) + class OverrideNew: + def __new__(cls, foo, kw=0, *args, **kwds): + return object.__new__(cls, *args, **kwds) + class OverrideInit: + def __init__(self, foo, kw=0, *args, **kwargs): + return object.__init__(self, *args, **kwargs) + class OverrideBoth(OverrideNew, OverrideInit): + pass + for case in OverrideNew, OverrideInit, OverrideBoth: + case(1) + case(1, kw=2) + self.assertRaises(TypeError, case, 1, 2, 3) + self.assertRaises(TypeError, case, 1, 2, foo=3) + class DictProxyTests(unittest.TestCase): def setUp(self): diff -r 561fc3b4cc2a -r 25b71858cb14 Misc/NEWS --- a/Misc/NEWS Fri Mar 16 22:46:14 2012 -0400 +++ b/Misc/NEWS Sat Mar 17 00:05:44 2012 -0500 @@ -10,6 +10,9 @@ Core and Builtins ----------------- +- Issue #1683368: object.__new__ and object.__init__ raise a TypeError if they + are passed arguments and their complementary method is not overridden. + - Give the ast.AST class a __dict__. - Issue #14334: Prevent in a segfault in type.__getattribute__ when it was not diff -r 561fc3b4cc2a -r 25b71858cb14 Objects/typeobject.c --- a/Objects/typeobject.c Fri Mar 16 22:46:14 2012 -0400 +++ b/Objects/typeobject.c Sat Mar 17 00:05:44 2012 -0500 @@ -2905,22 +2905,11 @@ object_init(PyObject *self, PyObject *args, PyObject *kwds) { int err = 0; - if (excess_args(args, kwds)) { - PyTypeObject *type = Py_TYPE(self); - if (type->tp_init != object_init && - type->tp_new != object_new) - { - err = PyErr_WarnEx(PyExc_DeprecationWarning, - "object.__init__() takes no parameters", - 1); - } - else if (type->tp_init != object_init || - type->tp_new == object_new) - { - PyErr_SetString(PyExc_TypeError, - "object.__init__() takes no parameters"); - err = -1; - } + PyTypeObject *type = Py_TYPE(self); + if (excess_args(args, kwds) && + (type->tp_new == object_new || type->tp_init != object_init)) { + PyErr_SetString(PyExc_TypeError, "object.__init__() takes no parameters"); + err = -1; } return err; } @@ -2928,26 +2917,12 @@ static PyObject * object_new(PyTypeObject *type, PyObject *args, PyObject *kwds) { - int err = 0; - if (excess_args(args, kwds)) { - if (type->tp_new != object_new && - type->tp_init != object_init) - { - err = PyErr_WarnEx(PyExc_DeprecationWarning, - "object.__new__() takes no parameters", - 1); - } - else if (type->tp_new != object_new || - type->tp_init == object_init) - { - PyErr_SetString(PyExc_TypeError, - "object.__new__() takes no parameters"); - err = -1; - } - } - if (err < 0) + if (excess_args(args, kwds) && + (type->tp_init == object_init || type->tp_new != object_new)) { + PyErr_SetString(PyExc_TypeError, "object.__new__() takes no parameters"); return NULL; - + } + if (type->tp_flags & Py_TPFLAGS_IS_ABSTRACT) { PyObject *abstract_methods = NULL; PyObject *builtins; /benjamin@python.org