(original) (raw)

changeset: 84799:4a69dbe71aeb user: Victor Stinner victor.stinner@gmail.com date: Mon Jul 22 23:50:57 2013 +0200 files: Objects/dictobject.c description: Issue #18520: Fix _PyDict_GetItemId(), suppress _PyUnicode_FromId() error As PyDict_GetItem(), _PyDict_GetItemId() suppresses all errors that may occur, for historical reasons. diff -r 9267a0b836b7 -r 4a69dbe71aeb Objects/dictobject.c --- a/Objects/dictobject.c Mon Jul 22 23:04:55 2013 +0200 +++ b/Objects/dictobject.c Mon Jul 22 23:50:57 2013 +0200 @@ -2684,8 +2684,10 @@ { PyObject *kv; kv = _PyUnicode_FromId(key); /* borrowed */ - if (kv == NULL) + if (kv == NULL) { + PyErr_Clear(); return NULL; + } return PyDict_GetItem(dp, kv); } /victor.stinner@gmail.com