cpython: 974ace29ee2d (original) (raw)

Mercurial > cpython

changeset 81587:974ace29ee2d 3.2

Issue #15989: Fix several occurrences of integer overflow when result of PyLong_AsLong() narrowed to int without checks. This is a backport of changesets 13e2e44db99d and 525407d89277. [#15989]

Serhiy Storchaka storchaka@gmail.com
date	Sat, 19 Jan 2013 12:26:26 +0200
parents	4a1a88d25fec
children	8f10c9eae183 101e821e5e70
files	Include/longobject.h Lib/ctypes/test/test_structures.py Lib/test/string_tests.py Lib/test/test_fcntl.py Lib/test/test_fileio.py Lib/test/test_io.py Lib/test/test_poll.py Lib/test/test_socket.py Modules/_ctypes/stgdict.c Modules/_io/_iomodule.c Modules/_io/fileio.c Modules/selectmodule.c Modules/socketmodule.c Objects/fileobject.c Objects/longobject.c Objects/unicodeobject.c
diffstat	16 files changed, 129 insertions(+), 20 deletions(-)[+] [-] Include/longobject.h 3 Lib/ctypes/test/test_structures.py 9 Lib/test/string_tests.py 11 Lib/test/test_fcntl.py 21 Lib/test/test_fileio.py 4 Lib/test/test_io.py 9 Lib/test/test_poll.py 10 Lib/test/test_socket.py 27 Modules/_ctypes/stgdict.c 2 Modules/_io/_iomodule.c 7 Modules/_io/fileio.c 2 Modules/selectmodule.c 12 Modules/socketmodule.c 6 Objects/fileobject.c 4 Objects/longobject.c 18 Objects/unicodeobject.c 4

line wrap: on

line diff

--- a/Include/longobject.h +++ b/Include/longobject.h @@ -26,6 +26,9 @@ PyAPI_FUNC(Py_ssize_t) PyLong_AsSsize_t( PyAPI_FUNC(size_t) PyLong_AsSize_t(PyObject *); PyAPI_FUNC(unsigned long) PyLong_AsUnsignedLong(PyObject *); PyAPI_FUNC(unsigned long) PyLong_AsUnsignedLongMask(PyObject *); +#ifndef Py_LIMITED_API +PyAPI_FUNC(int) _PyLong_AsInt(PyObject *); +#endif PyAPI_FUNC(PyObject ) PyLong_GetInfo(void); / It may be useful in the future. I've added it in the PyInt -> PyLong

--- a/Lib/ctypes/test/test_structures.py +++ b/Lib/ctypes/test/test_structures.py @@ -1,6 +1,7 @@ import unittest from ctypes import * from struct import calcsize +import _testcapi class SubclassesTest(unittest.TestCase): def test_subclass(self): @@ -199,6 +200,14 @@ class StructureTestCase(unittest.TestCas "pack": -1} self.assertRaises(ValueError, type(Structure), "X", (Structure,), d)

```
   # Issue 15989[](#l2.15)
```

   d = {"_fields_": [("a", c_byte)],[](#l2.16)

        "_pack_": _testcapi.INT_MAX + 1}[](#l2.17)

   self.assertRaises(ValueError, type(Structure), "X", (Structure,), d)[](#l2.18)

   d = {"_fields_": [("a", c_byte)],[](#l2.19)

        "_pack_": _testcapi.UINT_MAX + 2}[](#l2.20)

   self.assertRaises(ValueError, type(Structure), "X", (Structure,), d)[](#l2.21)

+ def test_initializers(self): class Person(Structure): fields = [("name", c_char*6),

--- a/Lib/test/string_tests.py +++ b/Lib/test/string_tests.py @@ -5,6 +5,7 @@ Common tests shared by test_str, test_un import unittest, string, sys, struct from test import support from collections import UserList +import _testcapi class Sequence: def init(self, seq='wxyz'): self.seq = seq @@ -1142,6 +1143,16 @@ class MixinStrUnicodeUserStringTest: self.checkraises(TypeError, '%10.*f', 'mod', ('foo', 42.)) self.checkraises(ValueError, '%10', 'mod', (42,))

   self.checkraises(OverflowError, '%*s', '__mod__',[](#l3.15)

                    (_testcapi.PY_SSIZE_T_MAX + 1, ''))[](#l3.16)

   self.checkraises(OverflowError, '%.*f', '__mod__',[](#l3.17)

                    (_testcapi.INT_MAX + 1, 1. / 7))[](#l3.18)

```
   # Issue 15989[](#l3.19)
```

   self.checkraises(OverflowError, '%*s', '__mod__',[](#l3.20)

                    (1 << (_testcapi.PY_SSIZE_T_MAX.bit_length() + 1), ''))[](#l3.21)

   self.checkraises(OverflowError, '%.*f', '__mod__',[](#l3.22)

                    (_testcapi.UINT_MAX + 1, 1. / 7))[](#l3.23)

+ class X(object): pass self.checkraises(TypeError, 'abc', 'mod', X())

--- a/Lib/test/test_fcntl.py +++ b/Lib/test/test_fcntl.py @@ -6,6 +6,7 @@ OS/2+EMX doesn't support the file lockin import os import struct import sys +import _testcapi import unittest from test.support import verbose, TESTFN, unlink, run_unittest, import_module @@ -76,6 +77,26 @@ class TestFcntl(unittest.TestCase): rv = fcntl.fcntl(self.f, fcntl.F_SETLKW, lockdata) self.f.close()

def test_fcntl_bad_file(self):
```
   class F:[](#l4.16)
```

       def __init__(self, fn):[](#l4.17)

```
           self.fn = fn[](#l4.18)
```
```
       def fileno(self):[](#l4.19)
```
```
           return self.fn[](#l4.20)
```

   self.assertRaises(ValueError, fcntl.fcntl, -1, fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.21)

   self.assertRaises(ValueError, fcntl.fcntl, F(-1), fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.22)

   self.assertRaises(TypeError, fcntl.fcntl, 'spam', fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.23)

   self.assertRaises(TypeError, fcntl.fcntl, F('spam'), fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.24)

```
   # Issue 15989[](#l4.25)
```

   self.assertRaises(OverflowError, fcntl.fcntl, _testcapi.INT_MAX + 1,[](#l4.26)

                                                 fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.27)

   self.assertRaises(OverflowError, fcntl.fcntl, F(_testcapi.INT_MAX + 1),[](#l4.28)

                                                 fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.29)

   self.assertRaises(OverflowError, fcntl.fcntl, _testcapi.INT_MIN - 1,[](#l4.30)

                                                 fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.31)

   self.assertRaises(OverflowError, fcntl.fcntl, F(_testcapi.INT_MIN - 1),[](#l4.32)

                                                 fcntl.F_SETFL, os.O_NONBLOCK)[](#l4.33)

+ def test_fcntl_64_bit(self): # Issue #1309352: fcntl shouldn't fail when the third arg fits in a # C 'long' but not in a C 'int'.

--- a/Lib/test/test_fileio.py +++ b/Lib/test/test_fileio.py @@ -7,6 +7,7 @@ import unittest from array import array from weakref import proxy from functools import wraps +import _testcapi from test.support import TESTFN, check_warnings, run_unittest, make_bad_fd from collections import UserList @@ -346,6 +347,9 @@ class OtherFileTests(unittest.TestCase): if sys.platform == 'win32': import msvcrt self.assertRaises(IOError, msvcrt.get_osfhandle, make_bad_fd())

```
   # Issue 15989[](#l5.15)
```

   self.assertRaises(TypeError, _FileIO, _testcapi.INT_MAX + 1)[](#l5.16)

   self.assertRaises(TypeError, _FileIO, _testcapi.INT_MIN - 1)[](#l5.17)

def testBadModeArgument(self): # verify that we get a sensible error message for bad mode argument

--- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -31,6 +31,7 @@ import signal import errno import warnings import pickle +import _testcapi from itertools import cycle, count from collections import deque, UserList from test import support @@ -1903,6 +1904,14 @@ class TextIOWrapperTest(unittest.TestCas t.write("A\rB") self.assertEqual(r.getvalue(), b"XY\nZA\rB")

Issue 15989
def test_device_encoding(self):
```
   b = self.BytesIO()[](#l6.17)
```

   b.fileno = lambda: _testcapi.INT_MAX + 1[](#l6.18)

   self.assertRaises(OverflowError, self.TextIOWrapper, b)[](#l6.19)

   b.fileno = lambda: _testcapi.UINT_MAX + 1[](#l6.20)

   self.assertRaises(OverflowError, self.TextIOWrapper, b)[](#l6.21)

+ def test_encoding(self): # Check the encoding attribute is always set, and valid b = self.BytesIO()

--- a/Lib/test/test_poll.py +++ b/Lib/test/test_poll.py @@ -1,6 +1,7 @@

Test case for the os.poll() function

import os, select, random, unittest +import _testcapi from test.support import TESTFN, run_unittest try: @@ -150,6 +151,15 @@ class PollTests(unittest.TestCase): if x != 5: self.fail('Overflow must have occurred')

```
   pollster = select.poll()[](#l7.15)
```
```
   # Issue 15989[](#l7.16)
```

   self.assertRaises(OverflowError, pollster.register, 0,[](#l7.17)

                     _testcapi.SHRT_MAX + 1)[](#l7.18)

   self.assertRaises(OverflowError, pollster.register, 0,[](#l7.19)

                     _testcapi.USHRT_MAX + 1)[](#l7.20)

   self.assertRaises(OverflowError, pollster.poll, _testcapi.INT_MAX + 1)[](#l7.21)

   self.assertRaises(OverflowError, pollster.poll, _testcapi.UINT_MAX + 1)[](#l7.22)

+ def test_main(): run_unittest(PollTests)

--- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -7,6 +7,7 @@ import errno import io import socket import select +import _testcapi import time import traceback import queue @@ -850,11 +851,17 @@ class GeneralModuleTests(unittest.TestCa self.assertRaises(ValueError, fp.writable) self.assertRaises(ValueError, fp.seekable)

def testListenBacklog0(self):

def test_listen_backlog(self):
```
   for backlog in 0, -1:[](#l8.17)
```

       srv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)[](#l8.18)

```
       srv.bind((HOST, 0))[](#l8.19)
```
```
       srv.listen(backlog)[](#l8.20)
```
```
       srv.close()[](#l8.21)
```

   # Issue 15989[](#l8.23)
   srv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)[](#l8.24)
   srv.bind((HOST, 0))[](#l8.25)

```
   # backlog = 0[](#l8.26)
```
```
   srv.listen(0)[](#l8.27)
```

   self.assertRaises(OverflowError, srv.listen, _testcapi.INT_MAX + 1)[](#l8.28)
   srv.close()[](#l8.29)

@unittest.skipUnless(SUPPORTS_IPV6, 'IPv6 required for this test.') @@ -954,6 +961,11 @@ class BasicTCPTest(SocketConnectedTest): def _testShutdown(self): self.serv_conn.send(MSG)

```
   # Issue 15989[](#l8.36)
```

   self.assertRaises(OverflowError, self.serv_conn.shutdown,[](#l8.37)

                     _testcapi.INT_MAX + 1)[](#l8.38)

   self.assertRaises(OverflowError, self.serv_conn.shutdown,[](#l8.39)

                     2 + (_testcapi.UINT_MAX + 1))[](#l8.40)
   self.serv_conn.shutdown(2)[](#l8.41)

def testDetach(self): @@ -1067,7 +1079,10 @@ class NonBlockingTCPTests(ThreadedTCPSoc def testSetBlocking(self): # Testing whether set blocking works

```
   self.serv.setblocking(0)[](#l8.48)
```

   self.serv.setblocking(True)[](#l8.49)

   self.assertIsNone(self.serv.gettimeout())[](#l8.50)

   self.serv.setblocking(False)[](#l8.51)

   self.assertEqual(self.serv.gettimeout(), 0.0)[](#l8.52)
   start = time.time()[](#l8.53)
   try:[](#l8.54)
       self.serv.accept()[](#l8.55)

@@ -1075,6 +1090,10 @@ class NonBlockingTCPTests(ThreadedTCPSoc pass end = time.time() self.assertTrue((end - start) < 1.0, "Error setting non-blocking mode.")

```
   # Issue 15989[](#l8.60)
```

   if _testcapi.UINT_MAX < _testcapi.ULONG_MAX:[](#l8.61)

       self.serv.setblocking(_testcapi.UINT_MAX + 1)[](#l8.62)

       self.assertIsNone(self.serv.gettimeout())[](#l8.63)

def _testSetBlocking(self): pass

--- a/Modules/_ctypes/stgdict.c +++ b/Modules/_ctypes/stgdict.c @@ -335,7 +335,7 @@ PyCStructUnionType_update_stgdict(PyObje isPacked = PyObject_GetAttrString(type, "pack"); if (isPacked) {

   pack = PyLong_AsLong(isPacked);[](#l9.7)

   pack = _PyLong_AsInt(isPacked);[](#l9.8)
   if (pack < 0 || PyErr_Occurred()) {[](#l9.9)
       Py_XDECREF(isPacked);[](#l9.10)
       PyErr_SetString(PyExc_ValueError,[](#l9.11)

--- a/Modules/_io/_iomodule.c +++ b/Modules/_io/_iomodule.c @@ -303,7 +303,8 @@ io_open(PyObject *self, PyObject *args, int text = 0, binary = 0, universal = 0; char rawmode[5], *m;

int line_buffering, isatty;

int line_buffering;
long isatty;

PyObject *raw, *modeobj = NULL, *buffer = NULL, *wrapper = NULL; @@ -441,12 +442,12 @@ io_open(PyObject *self, PyObject *args, #ifdef HAVE_STRUCT_STAT_ST_BLKSIZE { struct stat st;

```
       long fileno;[](#l10.17)
```

       int fileno;[](#l10.18)
       PyObject *res = PyObject_CallMethod(raw, "fileno", NULL);[](#l10.19)
       if (res == NULL)[](#l10.20)
           goto error;[](#l10.21)

       fileno = PyLong_AsLong(res);[](#l10.23)

       fileno = _PyLong_AsInt(res);[](#l10.24)
       Py_DECREF(res);[](#l10.25)
       if (fileno == -1 && PyErr_Occurred())[](#l10.26)
           goto error;[](#l10.27)

--- a/Modules/_io/fileio.c +++ b/Modules/_io/fileio.c @@ -240,7 +240,7 @@ fileio_init(PyObject *oself, PyObject *a return -1; }

fd = PyLong_AsLong(nameobj);

fd = _PyLong_AsInt(nameobj); if (fd < 0) { if (!PyErr_Occurred()) { PyErr_SetString(PyExc_ValueError,

--- a/Modules/selectmodule.c +++ b/Modules/selectmodule.c @@ -340,10 +340,13 @@ update_ufd_array(pollObject *self) i = pos = 0; while (PyDict_Next(self->dict, &pos, &key, &value)) {

   self->ufds[i].fd = PyLong_AsLong(key);[](#l12.7)

```
   assert(i < self->ufd_len);[](#l12.8)
```
```
   /* Never overflow */[](#l12.9)
```

   self->ufds[i].fd = (int)PyLong_AsLong(key);[](#l12.10)
   self->ufds[i].events = (short)PyLong_AsLong(value);[](#l12.11)
   i++;[](#l12.12)

}

assert(i == self->ufd_len); self->ufd_uptodate = 1; return 1; }

@@ -359,10 +362,11 @@ static PyObject * poll_register(pollObject *self, PyObject *args) { PyObject *o, *key, *value;

int fd, events = POLLIN | POLLPRI | POLLOUT;

int fd;
short events = POLLIN | POLLPRI | POLLOUT; int err;

if (!PyArg_ParseTuple(args, "O|i:register", &o, &events)) {

if (!PyArg_ParseTuple(args, "O|h:register", &o, &events)) { return NULL; } @@ -501,7 +505,7 @@ poll_poll(pollObject *self, PyObject *ar tout = PyNumber_Long(tout); if (!tout) return NULL;

   timeout = PyLong_AsLong(tout);[](#l12.36)

   timeout = _PyLong_AsInt(tout);[](#l12.37)
   Py_DECREF(tout);[](#l12.38)
   if (timeout == -1 && PyErr_Occurred())[](#l12.39)
       return NULL;[](#l12.40)

--- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -1737,7 +1737,7 @@ For IP sockets, the address info is a pa static PyObject * sock_setblocking(PySocketSockObject *s, PyObject *arg) {

int block;

long block;

block = PyLong_AsLong(arg); if (block == -1 && PyErr_Occurred()) @@ -2219,7 +2219,7 @@ sock_listen(PySocketSockObject *s, PyObj int backlog; int res;

backlog = PyLong_AsLong(arg);

backlog = _PyLong_AsInt(arg); if (backlog == -1 && PyErr_Occurred()) return NULL; Py_BEGIN_ALLOW_THREADS @@ -2822,7 +2822,7 @@ sock_shutdown(PySocketSockObject *s, PyO int how; int res;

how = PyLong_AsLong(arg);

how = _PyLong_AsInt(arg); if (how == -1 && PyErr_Occurred()) return NULL; Py_BEGIN_ALLOW_THREADS

--- a/Objects/fileobject.c +++ b/Objects/fileobject.c @@ -200,7 +200,7 @@ PyObject_AsFileDescriptor(PyObject *o) PyObject *meth; if (PyLong_Check(o)) {

```
   fd = PyLong_AsLong(o);[](#l14.7)
```

```
   fd = _PyLong_AsInt(o);[](#l14.8)
```
} else if ((meth = PyObject_GetAttrString(o, "fileno")) != NULL) { @@ -210,7 +210,7 @@ PyObject_AsFileDescriptor(PyObject *o) return -1;

if (PyLong_Check(fno)) {

       fd = PyLong_AsLong(fno);[](#l14.16)

       fd = _PyLong_AsInt(fno);[](#l14.17)
       Py_DECREF(fno);[](#l14.18)
   }[](#l14.19)
   else {[](#l14.20)

--- a/Objects/longobject.c +++ b/Objects/longobject.c @@ -424,6 +424,24 @@ PyLong_AsLong(PyObject obj) return result; } +/ Get a C int from a long int object or any object that has an int

method. Return -1 and set an error if overflow occurs. */ +

+int +_PyLong_AsInt(PyObject *obj) +{

int overflow;
long result = PyLong_AsLongAndOverflow(obj, &overflow);
if (overflow || result > INT_MAX || result < INT_MIN) {

   /* XXX: could be cute and give a different[](#l15.16)

      message for overflow == -1 */[](#l15.17)

   PyErr_SetString(PyExc_OverflowError,[](#l15.18)

                   "Python int too large to convert to C int");[](#l15.19)

```
   return -1;[](#l15.20)
```
}
return (int)result;

+} + /* Get a Py_ssize_t from a long int object. Returns -1 and sets an error condition if overflow occurs. */

--- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -9640,7 +9640,7 @@ PyObject *PyUnicode_Format(PyObject for " wants int"); goto onError; }

           width = PyLong_AsLong(v);[](#l16.7)

           width = PyLong_AsSsize_t(v);[](#l16.8)
           if (width == -1 && PyErr_Occurred())[](#l16.9)
               goto onError;[](#l16.10)
           if (width < 0) {[](#l16.11)

@@ -9677,7 +9677,7 @@ PyObject *PyUnicode_Format(PyObject for " wants int"); goto onError; }

               prec = PyLong_AsLong(v);[](#l16.16)

               prec = _PyLong_AsInt(v);[](#l16.17)
               if (prec == -1 && PyErr_Occurred())[](#l16.18)
                   goto onError;[](#l16.19)
               if (prec < 0)[](#l16.20)