(original) (raw)

changeset: 84695:97bb3bdf1443 user: Victor Stinner victor.stinner@gmail.com date: Wed Jul 17 21:58:01 2013 +0200 files: Objects/listobject.c description: Issue #18408: Fix listpop(), handle list_ass_slice() failure diff -r 573f7d485ce8 -r 97bb3bdf1443 Objects/listobject.c --- a/Objects/listobject.c Wed Jul 17 21:54:25 2013 +0200 +++ b/Objects/listobject.c Wed Jul 17 21:58:01 2013 +0200 @@ -934,12 +934,10 @@ } Py_INCREF(v); status = list_ass_slice(self, i, i+1, (PyObject *)NULL); - assert(status >= 0); - /* Use status, so that in a release build compilers don't - * complain about the unused name. - */ - (void) status; - + if (status < 0) { + Py_DECREF(v); + return NULL; + } return v; } /victor.stinner@gmail.com