cpython: a02adfb3260a (original) (raw)

Mercurial > cpython

changeset 87450:a02adfb3260a

Issue #17810: Add two missing error checks to save_global CID 1131946: Unchecked return value (CHECKED_RETURN) [#17810]

Christian Heimes christian@cheimes.de
date	Sat, 23 Nov 2013 21:13:39 +0100
parents	3c222d1f81e9
children	8a8392aff111
files	Modules/_pickle.c
diffstat	1 files changed, 4 insertions(+), 2 deletions(-)[+] [-] Modules/_pickle.c 6

line wrap: on

line diff

--- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -3193,8 +3193,10 @@ save_global(PicklerObject *self, PyObjec if (self->proto >= 4) { const char stack_global_op = STACK_GLOBAL;

       save(self, module_name, 0);[](#l1.7)

       save(self, global_name, 0);[](#l1.8)

       if (save(self, module_name, 0) < 0)[](#l1.9)

```
           goto error;[](#l1.10)
```

       if (save(self, global_name, 0) < 0)[](#l1.11)

```
           goto error;[](#l1.12)
```

if (_Pickler_Write(self, &stack_global_op, 1) < 0) goto error;