cpython: a4bdb637d818 (original) (raw)

Mercurial > cpython

changeset 78018:a4bdb637d818

revert the changes done for issue14826 - quoting witin Request is not desirable. [#14826]

line wrap: on

line diff

--- a/Lib/test/test_urllib.py +++ b/Lib/test/test_urllib.py @@ -1272,11 +1272,6 @@ class RequestTests(unittest.TestCase): request.method = 'HEAD' self.assertEqual(request.get_method(), 'HEAD')

• def test_quote_url(self):

•    Request = urllib.request.Request[](#l1.8)

•    request = Request("http://www.python.org/foo bar")[](#l1.9)

•    self.assertEqual(request.full_url, "http://www.python.org/foo%20bar")[](#l1.10)

- def test_main(): support.run_unittest(

--- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -264,7 +264,6 @@ class Request: method=None): # unwrap('URL:type://host/path') --> 'type://host/path' self.full_url = unwrap(url)

•    self.full_url = quote(self.full_url, safe="%/:=&?~#+!$,;'@()*[]|")[](#l2.7)
     self.full_url, self.fragment = splittag(self.full_url)[](#l2.8)
     self.data = data[](#l2.9)
     self.headers = {}[](#l2.10)

--- a/Misc/NEWS +++ b/Misc/NEWS @@ -31,11 +31,6 @@ Core and Builtins Library ------- -- Issue #14826: Quote urls in urllib.request.Request similar to how they

• are quoted by urllib.request.URLopener. Allows urls to spaces in them to work
• transparently with urllib.request.urlopen(...). Patch contributed by Stephen
• Thorne. -
• Issue #5931: wsgiref environ variable SERVER_SOFTWARE will specify an implementation specific term like Cpython, Jython instead of generic "Python"