(original) (raw)

Unless of course \`arc patch\` doesn't use the current directory as patch point! Thank you.

- Nicolas

On Fri, Feb 8, 2019 at 9:07 PM Nicolas Lesser <blitzrakete@gmail.com> wrote:
Hi,

On Fri, Feb 8, 2019 at 8:41 PM Mehdi AMINI <joker.eph@gmail.com> wrote:
Are you trying to apply a revision that was uploaded to Phabricator from one of the individual repository (or from SVN)?

Yes from clang if I understood your question correctly.
The issue if I remember correctly is that a patch uploaded from an SVN checkout would not start with \`llvm/\` or \`clang/\` and wouldn't be able to be applied in the monorepo. Conversely, a revision created from the monorepo can't be applied by \`arc patch\` in a single subproject checkout.
I don't think there is a way around this, maybe \`--strip-prefix\` and \`--add-prefix\` options could be added to \`arc patch\`, but I'm not sure it would fit the expectation of \`arc\` upstream.

That's what I thought too, but doing \`arc patch\` either in llvm-project/ or in llvm-project/clang/ doesn't change anything.

Thanks again,
- Nicolas