(original) (raw)

On Jul 21, 2020, at 11:50 AM, Jonathan Roelofs via llvm-dev <llvm-dev@lists.llvm.org> wrote:

A question of preference came up in https://reviews.llvm.org/D83588 as to whether we ought to prefer emitting TableGen error messages with all of the information in a single diagnostic, or whether it makes sense to split things in an error+note style as seen in many clang diagnostics. TableGen doesn’t use a DiagnosticsEngine, so the concept of a fatal note following an error is a bit new/foreign there, but perhaps something that makes sense adding.

Is there any precedence here for other internal llvm tooling (outside of clang)? What’s the general consensus here?