[css3-images] editorial comments from Tab Atkins Jr. on 2012-02-09 (www-style@w3.org from February 2012) (original) (raw)

On Wed, Feb 8, 2012 at 1:03 PM, Kang-Hao (Kenny) Lu <kennyluck@csail.mit.edu> wrote:

  1. Resolution Units: the type

Note that due to the 1:96 fixed ratio of CSS ‘in’ to CSS ‘px’, ‘1dppx’

is equivalent to ‘96dpi’. This corresponds to the default resolution

of images displayed in CSS: see ‘image-resolution’.

A friend of mime (John Hax in the Cc list) complains about this and he seems to think CSS2.1 Issue 149(px vs. pt)[1] should be resolved in favor of the pt-unit proposal (making only 'pt' physical).

The WG resolved that issue already, and I agree with it and won't revisit it for Images. I recommend reviewing the (lengthy) thread about the subject from last year, and if you still disagree, raising the issue with the WG in the context of the Values & Units spec, which is the current defining spec for the px unit.

  1. Gradients

The two functions described in this section allow an author to specify

such an image in a terse syntax

s/two/four ? Not sure if you want to count repeating-* in.

where , , ,

and are defined in their applicable

sections

below.

For some reason, only gets a xref.

Gradients are a type of image, and can be used anywhere an image

can, such as in the ‘background-image’ or ‘list-style-image’ properties.

This informative paragraph pretty much duplicates everything the following example (13) says and hence I think it can be dropped.

4.1.2. Linear Gradient Examples

Example 19

In the ED, the SVG gave me scroll bars. This was confusing when I first read this via Safari which hides the scroll bars and made me think this picture is wrong. No scroll bars please!

4.3. Repeating Gradients: the ‘repeating-linear-gradient()’ and ‘repeating-radial-gradient()’ notations

(Nitpicking) find the average color of a gradient → find the average color of a gradient for editorial consistency.

5.4. Sizing Objects: the ‘object-fit’ property

In the description of the 'none' value, I think you meant to link "object sizing algorithm" to the algorithm but missed it.

[1] http://wiki.csswg.org/spec/css2.1#issue-149

I've made all of these changes.

Please let me know if these resolutions are acceptable.

~TJ

Received on Thursday, 9 February 2012 10:36:58 UTC