[OpenJDK 2D-Dev] [7u8] request for review: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux. (original) (raw)
Andrew Brygin andrew.brygin at oracle.com
Mon Aug 20 11:30:13 UTC 2012
- Previous message: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux.
- Next message: [OpenJDK 2D-Dev] [7u8] request for review: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
could you please review a fix for 7150594?
This problem is triggered by the fix for CR 7113017. In particular, this fix replaces the malloc.h with stddef.h in mlib_types.h. This change leads to compiling mlib_sys.c without forward declaration for memalign() routine, and cause following warnings:
mlib_sys.c:96: warning: implicit declaration of function 'memalign' mlib_sys.c:96: warning: cast to pointer from integer of different size
This cause the problem on systems where size of integer is less than size of pointers: the pointer value is clamped, and usage of the clamped pointer causes the observed crash.
As per discussion for jdk8 fix, suggested solution for 7u8 is to roll back the original fix for 7113017.
Fix discussion for jdk8: http://mail.openjdk.java.net/pipermail/2d-dev/2012-August/002666.html 7u8 changeset for 7113017: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/45ef4cd48167
Please take a look.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150594 Webrev: http://cr.openjdk.java.net/~bae/7150594/7u8/webrev.00/
Thanks, Andrew
- Previous message: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux.
- Next message: [OpenJDK 2D-Dev] [7u8] request for review: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]