RFR: 8034944: (process) Improve subprocess handling on Solaris (original) (raw)

Martin Buchholz martinrb at google.com
Fri Mar 21 18:32:02 UTC 2014

OK, latest webrev looks much smaller, and appears to have only a port of changes from my changes to Linux from a few years ago. (please confirm). If so, Looks Good To Me.

While looking at this, I think bumping the thread stack size by a factor of 2 (32k => 64k) seems timely, since native stack requirements (native sizes, alignments and overhead) seem to increase over time. But I'd put that into a separate change.

On Fri, Mar 21, 2014 at 11:23 AM, Rob McKenna <rob.mckenna at oracle.com>wrote:

..just realised I had an out of date webrev up there, I've just updated in place in case anyone is looking at it.

-Rob

On 21/03/14 17:43, Rob McKenna wrote: Hi folks,

I'd like to push this change into JDK8 & 7. There is other work going on in 9 which will supersede this fix so there is likely no point in pushing to that release. This is backport of the threadpool specific changes from https://bugs.openjdk.java.net/browse/JDK-6944584 along with some cosmetic changes in order to keep the code somewhat similar. In a nutshell a new process reaper thread was spawned for every Process created by the JDK. This fix runs these reaper threads in a thread pool to save on thread creation when creating a lot of new processes. http://cr.openjdk.java.net/~robm/8034944/webrev.01/ -Rob

More information about the core-libs-dev mailing list