(original) (raw)

Hi,

The Assembler and CodeBuffer classes supply CodeComment / block\_comment()

functionality, which does not work with stubs. The comments are

not printed with +PrintStubCode or +PrintInterpreter because the

comments are lost when the code is turned into a Stub, while

they are kept if the code is copied to a CodeBlob.

We fixed this in our SAP JVM, and contributed the change to the

ppc-aix-port some while ago, see

I propose to add this fix to the OpenJDK mainline.

A webrev can be found here:

Basically the change passes the codeBuffer to the Stub

constructor, and adapts the disassembler to print the

comments.

In the debug build the InterpreterCodelet Stub has a new field

holding the code comments.

I also added some ttyLocks and \\\\ns to beautify the output.

Could somebody please create a bug id for this issue and review the changes?

Thank you and best regards,

Goetz