(original) (raw)

Looks good!

Thanks,
/Staffan

On 21 feb 2014, at 11:53, Markus Gronlund <markus.gronlund@oracle.com> wrote:

Greetings,
 
Kindly asking for reviews for the following changeset:
 
 
Problem statement summary and details are outlined in bug JDK-8035493 .
 
Testing completed:
 
nsk/jvmti/scenarios/\* (this includes JVMTI Hotswap and PopFrame testing)
hotspot/test/compiler/\*
 
Additionals:
 
I would like, if possible, if we could move away from intertwining specific jvmti capabilities inside the different compilers.
 
The existing code makes it difficult to evolve and extend with additional instructions to the compilers, esp. if we would like to pass results from higher level conditions, perhaps by combining contextual data with/without JVMTI. If possible, a suggestion would be the creation of a higher level interface which the ciEnv can query for compilation instructions� the implementations of this interface could then be shielded away and allow for any type of combinatorial logic � leaving the code in the compilers themselves untouched.
 
Thanks in advance
Markus