Hi Vladimir,

Yes, I've followed Aleksey's post for removing UseOldInling flag.
I'm just asking if this flag can be put into the obsolete_jvm_flags for
JDK 8 as well. That way you won't need to add the flag back to globals.hpp.

Is it not good because you can't even issue a warning for this flag in
JDK 8?

Not in Update release. We are talking about 8u20.

I see. Then this change looks good to me (not a Reviewer).

There are counter-examples to deprecating flags in a update release, though, e.g.
� { "Tier1Inline", � � � � JDK_Version::jdk_update(7,40), JDK_Version::jdk(8) },
I just though it'd be doable for JDK_Version::jdk_update(8, 20) as well...

Thanks,
Kris
�
">

(original) (raw)

Hi Vladimir,

On Fri, Feb 21, 2014 at 12:02 PM, Vladimir Kozlov <vladimir.kozlov@oracle.com> wrote:
On 2/21/14 11:52 AM, Krystal Mok wrote:
Hi Vladimir,

Yes, I've followed Aleksey's post for removing UseOldInling flag.
I'm just asking if this flag can be put into the obsolete\_jvm\_flags for
JDK 8 as well. That way you won't need to add the flag back to globals.hpp.

Is it not good because you can't even issue a warning for this flag in
JDK 8?

Not in Update release. We are talking about 8u20.

I see. Then this change looks good to me (not a Reviewer).

There are counter-examples to deprecating flags in a update release, though, e.g.
� { "Tier1Inline", � � � � JDK\_Version::jdk\_update(7,40), JDK\_Version::jdk(8) },
I just though it'd be doable for JDK\_Version::jdk\_update(8, 20) as well...

Thanks,
Kris
�

Thanks,

Vladimir



Thanks,
Kris


On Fri, Feb 21, 2014 at 11:39 AM, Vladimir Kozlov
<vladimir.kozlov@oracle.com <mailto:vladimir.kozlov@oracle.com>> wrote:

� � Kris,

� � The flag name is deceiving. We only used code with UseOldInlining=true.
� � The code which was removed was under !UseOldInlining (negated). We
� � kept the code which was under UseOldInlining. So the behavior did
� � not changed. And the flag is in deprecated list:

� � + { "UseOldInlining", JDK\_Version::jdk(9), JDK\_Version::jdk(10) },

� � Thanks,
� � Vladimir


� � On 2/21/14 11:15 AM, Krystal Mok wrote:

� � � � Hi Vladimir,

� � � � Restoring a flag without backing code is a little bit weird. Is is
� � � � possible to put it in the deprecated flags list instead?

� � � � Thanks,
� � � � Kris


� � � � On Fri, Feb 21, 2014 at 10:41 AM, Vladimir Kozlov
� � � � <vladimir.kozlov@oracle.com <mailto:vladimir.kozlov@oracle.com>

� � � � <mailto:vladimir.kozlov@__oracle.com

� � � � <mailto:vladimir.kozlov@oracle.com>>> wrote:



� � � � https://bugs.openjdk.java.net/____browse/JDK-8035585

� � � � <https://bugs.openjdk.java.net/__browse/JDK-8035585>

� � � � � � �<https://bugs.openjdk.java.__net/browse/JDK-8035585

� � � � <https://bugs.openjdk.java.net/browse/JDK-8035585>>

� � � � http://cr.openjdk.java.net/~____kvn/8035585/webrev/

� � � � <http://cr.openjdk.java.net/~__kvn/8035585/webrev/>





� � � � � � �<http://cr.openjdk.java.net/~__kvn/8035585/webrev/

� � � � <http://cr.openjdk.java.net/~kvn/8035585/webrev/>>



� � � � � � �I backported 8032490 changes which removed UseOldInlining

� � � � flags. We

� � � � � � �can't do that in update release.

� � � � � � �Restore the flag but keep code changes. The removed code

� � � � was never

� � � � � � �used, tested and was rotten.



� � � � � � �Thanks,

� � � � � � �Vladimir