This one has been in my patch queue for a long time, I'd actually     forgotten about it. It's also just a clean-up covering two issues:
    
    1. UnixNativeDispatcher defines          getextmntent to read an entry from the     mount table but it's not very portable with lots of #ifdef for each     platform. The change moves this method down to     SolarisNativeDispatcher and adds a getmntent to     LinuxNativeDispatcher so it's much cleaner.
    
    2. When the Mac port was added then it included the GNOME     FileTypeDetector which I don't think makes sense because it will     never be used. The clean-up here is to not build this     FileTypeDetector on Mac. The DefaultFileTypeDetector that is     compiled when building on Solaris/Linux/Mac is changed so that it     delegates to the FileSystemProvider to get the file type detector     and this ensures that the proper implementation is included.
    
    As I say, this is solely clean-up so there isn't a test. The webrev     with the changes is here:
    
    http://cr.openjdk.java.net/~alanb/7191556/webrev/
    
    -Alan.
   ">

(original) (raw)


This one has been in my patch queue for a long time, I'd actually forgotten about it. It's also just a clean-up covering two issues:

1\. UnixNativeDispatcher defines getextmntent to read an entry from the mount table but it's not very portable with lots of #ifdef for each platform. The change moves this method down to SolarisNativeDispatcher and adds a getmntent to LinuxNativeDispatcher so it's much cleaner.

2\. When the Mac port was added then it included the GNOME FileTypeDetector which I don't think makes sense because it will never be used. The clean-up here is to not build this FileTypeDetector on Mac. The DefaultFileTypeDetector that is compiled when building on Solaris/Linux/Mac is changed so that it delegates to the FileSystemProvider to get the file type detector and this ensures that the proper implementation is included.

As I say, this is solely clean-up so there isn't a test. The webrev with the changes is here:

http://cr.openjdk.java.net/\~alanb/7191556/webrev/

\-Alan.