code review request for minor FDS tweak (7157296, 7158067) (original) (raw)

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Apr 2 12:38:35 PDT 2012

Dan,

I've reviewed all 3 webrevs. They look fine.

Thanks, Serguei

On 3/30/12 10:32 AM, Daniel D. Daugherty wrote:

Greetings,

In my recent Full Debug Symbols changes, I added the new ENABLEFULLDEBUGSYMBOLS build flag. I originally implemented this flag to disable debug info for all build configs which doesn't make a whole lot of sense for non-product builds. After all what's a debug build without debug info? (Pretty much the same thing as a product build). As is usual, I have one bug to track the hotspot repo changes and another bug to track the other repos: 7157296 3/4 FDS: ENABLEFULLDEBUGSYMBOLS flag should only affect OPT builds 7158067 4/4 FDS: ENABLEFULLDEBUGSYMBOLS flag should only affect product builds Here are the webrev URLs: http://cr.openjdk.java.net/~dcubed/fdsrevamp/7157296-webrev/0-jdk8-root/ http://cr.openjdk.java.net/~dcubed/fdsrevamp/7158067-webrev/0-jdk8-hotspot/ http://cr.openjdk.java.net/~dcubed/fdsrevamp/7157296-webrev/0-jdk8-jdk/ Thanks, in advance, for any review comments. Dan

-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120402/c45486fe/attachment.html

More information about the serviceability-dev mailing list