(original) (raw)

Hi Charles,

On 10/03/2011 05:40 PM, Pavel Porvatov wrote:

Hi Charles,

On 09/22/2011 05:18 PM, Neil Richards wrote:

On Thu, 2011-09-22 at 14:21 +0800, Charles Lee wrote:

Hi guys,

The webrev is attached.

For ease of review, I've uploaded the webrev to cr.openjdk.java.net \[1\]

Regards, Neil

\[1\] http://cr.openjdk.java.net/\~ngmr/6938583/webrev.00

Hi guys,

Any update about this issue? Is the idea workable?

Can you explain why should we consume right clicks but not left ones? (May be there are other test cases when NPE is thrown... ) And why do you consume event? (May be it hides NPE but breaks functionality)

Thanks, Pavel

1\. When right clicks, it suppose to show a manu on where you click. But I guess the demo (CodePointIM) is not suppose to show that (what will be show when use CodePointIM and right click? IIRC, I tried the normal input and right click but get nothing)
2\. If point 1 is true, consuming the right click in the CodePointIM is the easiest way to fix it and less error-prone comparing with fixing in the jdk...
3\. Consuming left click will disable the movement of the input place by clicking, I guess...

There is no information about popup menu in the bug description. The problem is that endComposition() throws NPE if Input Method is turned on and the program is in composition mode. If you apply your fix and change BUTTON3 into BUTTON2 in the MouseEventTest2 test (see bug description), then NPE will be thrown with your patch as well...

Regards, Pavel

--   
Yours Charles