[Python-Dev] Re: [Python-checkins] python/dist/src/Lib pprint.py,1.24,1.25 (original) (raw)

Fred L. Drake, Jr. fdrake@acm.org
Sat, 7 Jun 2003 16:27:27 -0400

loewis@users.sourceforge.net writes:

Modified Files: pprint.py Log Message: Patch #750542: Use issubclass instead of type identity.

Hmm; this patch was never assigned to me, so I was unaware that anyone thought there was a problem with this.

I specifically considered making changes like these when subclassing built-in types became possible, but decided against it since it didn't appear reasonable to assume that repr() hadn't been redefined. I'm sure it's possible to check, but to do so cleanly and efficiently seems like a huge change to the module for little value.

I think the patch, as it stands, should be reverted. If another patch appears that addresses the issue of overridden repr() methods, it should be considered again.

-1 for the patch as applied.

-Fred

-- Fred L. Drake, Jr. PythonLabs at Zope Corporation