[Python-Dev] [Python-checkins] buildbot warnings in hppa Ubuntu dapper trunk (original) (raw)

Tim Peters tim.peters at gmail.com
Fri Jun 9 06:21:45 CEST 2006

[Tim]

Well, this sure sucks. This is the earliest revision at which the tests fail:

""" r46752 | georg.brandl | 2006-06-08 10:50:53 -0400 (Thu, 08 Jun 2006) | 3 lines Changed paths: M /python/trunk/Lib/test/testfile.py Convert testfile to unittest. """ If that's not a reason for using doctest, I don't know what is ;-)

[Brett]

That's hilarious! OK, that's it. I am definitely focusing my efforts for 2.6 in improving testing.

LOL. Believe it or not, we wouldn't have had a problem here if doctest had been used instead -- but the reason isn't particularly sane ;-)

Before the conversion, test_file.py ended with:

try: bug801631() finally: os.unlink(TESTFN)

so that TESTFN got removed no matter what. Some of the individual tests here are careless about cleaning up after themselves, and that last clause used to hide a multitude of lazy sins. A doctest would naturally also have ended with a "clean up the mess" block.

After the conversion to unittest, there was no final cleanup block, and it just so happened that "testUnicodeOpen" has the alphabetically largest test name, so unittest runs it last, and testUnicodeOpen() was one of the lazy tests that didn't clean up after itself.

What that has to do with test_optparse is left as an exercise for the reader ;-)

More information about the Python-Dev mailing list