(original) (raw)

On Fri, Jul 20, 2012 at 4:12 PM, Antoine Pitrou <solipsis@pitrou.net> wrote:

On Fri, 20 Jul 2012 20:49:03 +0200 (CEST)
brett.cannon <python-checkins@python.org> wrote:
> diff --git a/Lib/importlib/test/\_\_init\_\_.py b/Lib/test/test\_importlib/\_\_init\_\_.py
> rename from Lib/importlib/test/\_\_init\_\_.py
> rename to Lib/test/test\_importlib/\_\_init\_\_.py
> --- a/Lib/importlib/test/\_\_init\_\_.py
> +++ b/Lib/test/test\_importlib/\_\_init\_\_.py
> @@ -1,5 +1,6 @@
> import os
> import sys
> +from .. import support

I don't know if I'm only speaking for myself, but I really have trouble
parsing non-trivial relative imports,

I obviously don't, but then again I would hope I of all people could comprehend them after all this time. =)

and I personally prefer when

people use absolute imports (e.g. "from test import support").

So I changed the import above, but I'm not going to go through and change every other relative import that stays within test.test_importlib. I'm fine if someone else wants to change them, but I leave that as an exercise for the reader.

-Brett

cheers

Antoine.

\--
Software development and contracting: http://pro.pitrou.net

\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/brett%40python.org