(original) (raw)
On Sun, Dec 2, 2012 at 4:56 PM, christian.heimes <python-checkins@python.org> wrote:
Please don't write NEWS entries in past tense like this - they're annoyingly ambiguous, as it isn't clear whether the entry is describing the reported problem or the fix for the problem. Describing just the new behaviour or the original problem and the fix is much easier to follow. For example:
� - Issue #16592: stringlib\_bytes\_join now correctly raises MemoryError on allocation failure.
� - Issue #16592: stringlib\_bytes\_join was triggering SystemError on allocation failure. It now correctly raises MemoryError.
Issue titles for actual bugs generally don't make good NEWS entries, as they're typically a summary of the problem rather than the solution (RFE's are different, as there the issue title is often a good summary of the proposed change)
Cheers,
Nick.
http://hg.python.org/cpython/rev/9af5a2611202
changeset: � 80672:9af5a2611202
user: � � � �Christian Heimes <christian@cheimes.de>
date: � � � �Sun Dec 02 07:56:42 2012 +0100
summary:
� Issue #16592: stringlib\_bytes\_join doesn't raise MemoryError on allocation failure
files:
� Misc/NEWS � � � � � � � �| �3 +++
� Objects/stringlib/join.h | �1 +
� 2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/Misc/NEWS b/Misc/NEWS
\--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
�Core and Builtins
�-----------------
+- Issue #16592: stringlib\_bytes\_join doesn't raise MemoryError on allocation
\+ �failure.
Please don't write NEWS entries in past tense like this - they're annoyingly ambiguous, as it isn't clear whether the entry is describing the reported problem or the fix for the problem. Describing just the new behaviour or the original problem and the fix is much easier to follow. For example:
� - Issue #16592: stringlib\_bytes\_join now correctly raises MemoryError on allocation failure.
� - Issue #16592: stringlib\_bytes\_join was triggering SystemError on allocation failure. It now correctly raises MemoryError.
Issue titles for actual bugs generally don't make good NEWS entries, as they're typically a summary of the problem rather than the solution (RFE's are different, as there the issue title is often a good summary of the proposed change)
Cheers,
Nick.
--
Nick Coghlan�� |�� ncoghlan@gmail.com�� |�� Brisbane, Australia