2012/12/29 Eli Bendersky <eliben@gmail.com>:
> Hi,
>
> This came up while investigating some test-order-dependency failures in
> issue 16076.
>
> test___all__ goes over modules that have `__all__` in them and does 'from
 import *' on them. This leaves a lot of modules in sys.modules,
> which may interfere with some tests that do fancy things with sys,modules.
> In particular, the ElementTree tests have trouble with it because they
> carefully set up the imports to get the C or the Python version of etree
> (see issues 15083 and 15075).
>
> Would it make sense to save the sys.modules state and restore it in
> test___all__ so that sys.modules isn't affected by this test?

Sounds reasonable to me.

Thanks. http://bugs.python.org/issue16817

Eli

">

(original) (raw)




On Sat, Dec 29, 2012 at 4:46 PM, Benjamin Peterson <benjamin@python.org> wrote:
2012/12/29 Eli Bendersky <eliben@gmail.com>:
> Hi,
\>
\> This came up while investigating some test-order-dependency failures in
\> issue 16076.
\>
\> test\_\_\_all\_\_ goes over modules that have \`\_\_all\_\_\` in them and does 'from
\> import \*' on them. This leaves a lot of modules in sys.modules,
\> which may interfere with some tests that do fancy things with sys,modules.
\> In particular, the ElementTree tests have trouble with it because they
\> carefully set up the imports to get the C or the Python version of etree
\> (see issues 15083 and 15075).
\>
\> Would it make sense to save the sys.modules state and restore it in
\> test\_\_\_all\_\_ so that sys.modules isn't affected by this test?

Sounds reasonable to me.



--

Regards,

Benjamin