On 14/05/13 16:51, Gregory P. Smith wrote:
[...]
This sounds like a feature request for doctest. �doctest could be educated
about enums and automatically compare to the integer value for such cases.

Please no. Enums are not special enough to break the rules.

Good: "Doctests look at the object's repr."

Bad: "Doctests look at an object's repr, unless the object is an Enum, when it will look at the enum's value."

If I want a test that checks the enum's value, then I will write a doctest that explicitly checks the enum's value.



-- 
Steven
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/greg%40krypto.org

">

(original) (raw)

Bad: doctests.


On Tue, May 14, 2013 at 5:08 AM, Steven D'Aprano <steve@pearwood.info> wrote:
On 14/05/13 16:51, Gregory P. Smith wrote:
\[...\]

This sounds like a feature request for doctest. �doctest could be educated
about enums and automatically compare to the integer value for such cases.

Please no. Enums are not special enough to break the rules.

Good: "Doctests look at the object's repr."

Bad: "Doctests look at an object's repr, unless the object is an Enum, when it will look at the enum's value."

If I want a test that checks the enum's value, then I will write a doctest that explicitly checks the enum's value.



\--
Steven

\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/greg%40krypto.org