(original) (raw)
Complain to Antoine I suppose. :)\>> 2013/9/26 Eli Bendersky <eliben@gmail.com>:
\>> > Hi All,
\>> >
\>> > Earlier this morning I had a slight tackle with a couple of the 3.4 bots
\>> > (sorry everyone!). I fixed some problems in asdl.py -
\>> > http://hg.python.org/cpython/rev/21d46e3ae60c - and used the 'with'
\>> > statement. Some bots don't have Python 2.6+ and couldn't bootstrap
\>> > Python-ast.h/c
\>> >
\>> > Two questions:
\>> >
\>> > \* Should I always check-in Python-ast.h and Python-ast.c when I touch
\>> > asdl\*
\>> > ? The generated files are unchanged, it's only the timestamp that
\>> > changed.
\>> > \* Can we, in theory, use new Pythons for asdl\* code, because
\>> > Python-ast.\*
\>> > are, in fact, checked in so they don't have to be rebuilt by the bots or
\>> > users?
\>>
\>> We should have the buildbots run "make touch", so they don't need to
\>> run asdl\_c.py.
\>
\>
\> How should we go about doing this?
\[+ Antoine\]
Done :)
Done :)
While we're at it, it seems that .hgtouch is wrong:
Include/ast.h: Parser/Python.asdl Parser/asdl.py Parser/asdl\_c.py
Include/ast.h: Parser/Python.asdl Parser/asdl.py Parser/asdl\_c.py
Python/Python-ast.c: Include/ast.h
The file Include/ast.h is not, in fact, auto-generated. But Include/Python-ast.h *is*, and it does not appear in this file.
Typo? [+Ezio]
Eli