(original) (raw)

New C APIs should either be documented or have an underscore prefix.

Also, if they're part of the stable ABI, they need a version guard.

Wishlist item: an automated ABI checker that can diff the exported symbols against a reference list (Could ctypes or cffi be used for that?)

As long as this kind of thing involves manual review, we're going to keep making similar mistakes :P

That said, a potentially simpler first step would be a list of common mistakes to check for/questions to ask during reviews as part of the devguide.

Cheers,
Nick.