(original) (raw)

But I also discovered that I must have not pushed the latest copy yesterday.

It's on a machine at home -- I'll push it tonight. But the copy on gitHub now is mostly good -- I think the only changes are handling the docsstrings better and some more/better tests.

-Chris

On Sun, May 17, 2015 at 4:16 PM, Christian Heimes <christian@python.org> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 2015-05-18 01:02, Chris Barker wrote:
\> \* Is there a better way to create a False or True than::
\>
\> PyBool\_FromLong(0) and PyBool\_FromLong(1)

You can use the macros Py\_RETURN\_TRUE and Py\_RETURN\_FALSE instead of
return PyBool\_FromLong(0).


\> \* Style question: should I put brackets in an if clause that has
\> only one line?::
\>
\> if (some\_check) { just\_this\_one\_expression }

I prefer the extra brackets because they make the code more explicit.
It's really a matter of taste.

\> \* I can't find docs for PyDoc\_STRVAR: but it looks like it should
\> use it -- how?

PyDoc\_STRVAR(functionname\_doc,
"isclose(foo) -> bool\\n\\
\\n\\
long doc string.");

\> \* I'm getting a warning in my PyMethodDef clause::
\>
\> static PyMethodDef IsCloseMethods\[\] = { {"isclose", isclose\_c,
\> METH\_VARARGS | METH\_KEYWORDS, "determine if two floating point
\> numbers are close"}, {NULL, NULL, 0, NULL} /\* Sentinel \*/
\> };

You have to type cast the function pointer to a PyCFunction here:

(PyCFunction)isclose\_c

The type cast is required for KEYWORD functions and NOARGS functions.

Christian

Christopher Barker, Ph.D.
Oceanographer

Emergency Response Division
NOAA/NOS/OR&R (206) 526-6959 voice
7600 Sand Point Way NE (206) 526-6329 fax
Seattle, WA 98115 (206) 526-6317 main reception

Chris.Barker@noaa.gov