(original) (raw)

On Sat, Aug 19, 2017, 01:43 Antoine Pitrou <solipsis@pitrou.net> wrote:

On Fri, 18 Aug 2017 16:33:27 -0400

Yury Selivanov <yselivanov.ml@gmail.com> wrote:

>

> There are a few open questions left, namely the terminology

> and design of ContextKey API. On the former topic, I'm quite

> happy with the latest version: Execution Context, Logical

> Context, and Context Key.

I don't really like it. "Logical Context" is vague (there are

lots of things called "context" in other libraries, so a bit of

specificity would help avoid confusion), and it's not clear what is

"logical" about it anyway. "Local Context" actually seemed better to

me (as it reminded of threading.local() or the general notion of

thread-local storage).

I have to admit that I didn't even pick up on that name change. I could go either way.

I do appreciate dropping ContextItem, though, because "CI" makes me think of continuous integration. And the overall shape of the API for public consumption LGTM.

-brett

Regards

Antoine.

_______________________________________________

Python-Dev mailing list

Python-Dev@python.org

https://mail.python.org/mailman/listinfo/python-dev

Unsubscribe: https://mail.python.org/mailman/options/python-dev/brett%40python.org