(original) (raw)

Thanks Serhiy, I missed adding PyThread\_tss\_\* to Doc/data/refcounts.dat. I opened a PR to fix it.
https://github.com/python/cpython/pull/7038

Regards,
Masayuki

2018-05-21 21:41 GMT+09:00 Serhiy Storchaka <storchaka@gmail.com>:
Please don't forgot to perform the following steps when add a new public C API:

\* Document it in Doc/c-api/.

\* Add an entry in the What's New document.

\* Add it in Doc/data/refcounts.dat.

\* Add it in PC/python3.def.

If you want to include it in the limited API, wrap its declaration with:

#if !defined(Py\_LIMITED\_API) || Py\_LIMITED\_API+0 >= 0x03080000
#endif

(use the correct Python version of introducing a feature in the comparison)

If you don't want to include it in the limited API, wrap its declaration with:

#ifndef Py\_LIMITED\_API
#endif

You are free of adding private C API, but its name should start with \_Py or \_PY and its declaration should be wrapped with:

#ifndef Py\_LIMITED\_API
#endif

\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: https://mail.python.org/mailman/options/python-dev/ma3yuki.8mamo10%40gmail.com