(original) (raw)

On Mon, Oct 1, 2018, at 12:12, Michael Felt wrote:  

Hi all,

Before I submit a patch to increase the default MAXDATA setting for AIX
when in 32-bit mode - I want to know if I can put this LDFLAG setting in
LDLAST, or if I should introduce a new AC_SUBST() variable (e.g.,
LDMAXDATA).

I think you should just put it in LDFLAGS.

I was wanting to avoid that, as LDFLAGS is an environmental
variable.



At the surface, it appears Python is using PY_LDFLAGS (with
CONFIGURE_LDFLAGS coming from LDFLAGS during the ./configure
moment.



A reason for a separate variable is that this particular option is
only relevant for the python EXE, and not for shared libraries and
"other things". IMHO, a reason for LDMAXDATA is because LDLAST is
actually already too widely used:



root@x066:[/data/prj/python/git/cpython-master]grep LDFLAGS *.in

Makefile.pre.in:CONFIGURE_LDFLAGS= @LDFLAGS@

Makefile.pre.in:# Avoid assigning CFLAGS, LDFLAGS, etc. so users
can use them on the

Makefile.pre.in:# Both CPPFLAGS and LDFLAGS need to contain the
shell's value for setup.py to

Makefile.pre.in:PY_LDFLAGS= (CONFIGURELDFLAGS)(CONFIGURE_LDFLAGS) (CONFIGURELDFLAGS)(LDFLAGS)

Makefile.pre.in:LDSHARED= @LDSHARED@ $(PY_LDFLAGS)

Makefile.pre.in:BLDSHARED= @BLDSHARED@ $(PY_LDFLAGS)

Makefile.pre.in:OPENSSL_LDFLAGS=@OPENSSL_LDFLAGS@

Makefile.pre.in: $(MAKE) @DEF_MAKE_RULE@
CFLAGS_NODIST="$(CFLAGS) (PGOPROFGENFLAG)"LDFLAGS="(PGO_PROF_GEN_FLAG)" LDFLAGS="(PGOPROFGENFLAG)"LDFLAGS="(LDFLAGS)
(PGOPROFGENFLAG)"LIBS="(PGO_PROF_GEN_FLAG)" LIBS="(PGOPROFGENFLAG)"LIBS="(LIBS)"

Makefile.pre.in: $(MAKE) @DEF_MAKE_RULE@
CFLAGS_NODIST="$(CFLAGS) $(PGO_PROF_USE_FLAG)"
LDFLAGS="$(LDFLAGS)"

Makefile.pre.in: (LINKCC)(LINKCC) (LINKCC)(PY_LDFLAGS) $(LINKFORSHARED)
-o @Programs/python.o@ Programs/python.o @Programs/python.o(BLDLIBRARY) (LIBS)(LIBS) (LIBS)(MODLIBS)
(SYSLIBS)(SYSLIBS) (SYSLIBS)(LDLAST)

Makefile.pre.in: $(CC) -dynamiclib -Wl,-single_module
$(PY_LDFLAGS) -undefined dynamic_lookup
-Wl,-install_name,$(prefix)/lib/libpython$(LDVERSION).dylib
-Wl,-compatibility_version,$(VERSION)
-Wl,-current_version,$(VERSION) -o @@ @(LIBRARY_OBJS) $(SHLIBS)
(LIBC)(LIBC) (LIBC)(LIBM) $(LDLAST); \

Makefile.pre.in: (CC)−o(CC) -o (CC)−o(LDLIBRARY) $(PY_LDFLAGS)
-dynamiclib \

Makefile.pre.in: (LINKCC)(LINKCC) (LINKCC)(PY_LDFLAGS) $(LINKFORSHARED)
-o @Programs/testembed.o@ Programs/_testembed.o @Programs/testembed.o(BLDLIBRARY) (LIBS)(LIBS) (LIBS)(MODLIBS)
(SYSLIBS)(SYSLIBS) (SYSLIBS)(LDLAST)

Makefile.pre.in: (LINKCC)(LINKCC) (LINKCC)(PY_LDFLAGS) -o $@
Programs/_freeze_importlib.o (LIBRARYOBJSOMITFROZEN)(LIBRARY_OBJS_OMIT_FROZEN) (LIBRARYOBJSOMITFROZEN)(LIBS)
(MODLIBS)(MODLIBS) (MODLIBS)(SYSLIBS) $(LDLAST)

Makefile.pre.in: (CC)(CC) (CC)(OPT) $(PY_LDFLAGS)
(PGENOBJS)(PGENOBJS) (PGENOBJS)(LIBS) -o $(PGEN)



The ONLY line that needs $LDMAXDATA is:



Makefile.pre.in: (LINKCC)(LINKCC) (LINKCC)(PY_LDFLAGS) -o $@
Programs/_freeze_importlib.o (LIBRARYOBJSOMITFROZEN)(LIBRARY_OBJS_OMIT_FROZEN) (LIBRARYOBJSOMITFROZEN)(LIBS)
(MODLIBS)(MODLIBS) (MODLIBS)(SYSLIBS) (LDLAST)(LDLAST) (LDLAST)(LDMAXDATA)



or set (LDLAST)attheendratherthanappend(LDLAST) at the end rather than append (LDLAST)attheendratherthanappend(LDMAXDATA)

I have not looked yet, but I was thinking that MAYBE! LDLAST is intended
as a last resort variable that can be modified in Makefile.

LDLAST looks vestigial from OSF/1 support and should probably be removed.

On 10/2/2018 2:51 PM, Łukasz Langa
wrote: